-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Romanian localization #6456
Romanian localization #6456
Conversation
As a fellow translator, it's always great to see another localization for Bluesky! Just so you're aware, one thing to mention is that the devs ask that a localization PR is reviewed by at least one other native speaker. They seem fairly flexible on how that requirement is met though, so I don't think the person necessarily has to have a GitHub account. It could be a fellow Romanian speaker on Bluesky, for instance :) |
@@ -51,6 +52,7 @@ export const APP_LANGUAGES: AppLanguageConfig[] = [ | |||
{code2: AppLanguage.ko, name: '한국어 – Korean'}, | |||
{code2: AppLanguage.pt_BR, name: 'Português (BR) – Portuguese (BR)'}, | |||
{code2: AppLanguage.ru, name: 'Русский – Russian'}, | |||
{code2: AppLanguage.ro, name: 'Română – Romanian'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a tiny suggested tweak here: would it be possible to keep the languages in alphabetical order by code2
and put the Romanian entry above the Russian one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Thanks
I was pointed to this PR after I've submitted my own PR last night / this morning. I have a few concerns (I'm using separators or larger spaces between each issue): If you were to compare my PR with yours, you will notice that we both address users differently. My PR uses the formal "Dumneavoastră" and the "Dvs." abbreviation, while your PR uses the impersonal "Tu", "Tine", "Voi", etc. This is not wrong at all or an issue, there are many ways to address an user, and the impersonal variant shouldn't usually be a problem, because even Facebook addresses the user impersonally which seems fitting for a social media app. Not sure about Twitter, though. Ultimately, it's up to Bluesky to decide if they want to address the user(s) formally or informally. -- For the Romanian For Starter Packs, consider using "Pachet de început" instead of "Pachet de start", no reason to combine Romanian with English words where it's unnecessary. -- social-app/src/locale/locales/ro/messages.po Lines 136 to 137 in f2163c4
Consider using gender-neutral forms. Instead of "Avatarul lui" you can use "Avatarul folosit de". While sure, if the translation mentioned the user , "{0} user's avatar", then it would be correct to use the masculine "Avatarul lui {0}" or "Avatarul utilizatorului {0}", but since it's not, it would be much more appropriate to use something neutral, because {0} is likely replaced with the display name of the user.
You missed replacing social-app/src/locale/locales/ro/messages.po Lines 226 to 227 in f2163c4
-- Stick to "a redistribui" for consistency instead of various synonyms of social-app/src/locale/locales/ro/messages.po Lines 278 to 279 in f2163c4
-- Consider using "citări" instead of "citate", because you're browsing quotes (as in cites, an action, not as in actual quotes). Not a big deal, but there's a slight difference between the two. social-app/src/locale/locales/ro/messages.po Lines 90 to 91 in f2163c4
-- These are post controls, you have to keep the form out of brackets as a direct action for the user. social-app/src/locale/locales/ro/messages.po Lines 93 to 95 in f2163c4
The correct version would be: msgstr "{0, plural, one {Răspunde (# răspuns)} few {Răspunde (# răspunsuri)} other {Răspunde (# de răspunsuri)}}" ,because PostCtrls would look something like this: Reply (x amount of replies) Repost (y amount of reposts) Like (z amount of likes)
-- Obviously wrong. Romanian does not have an equivalent to a user handle specifically, so you'd have to use the Romanian equivalent of 'user name' instead, "Nume de utilizator". The literal meaning of "mâner" is the handle of a door, or the part of an object that you can grab and maneuver, and it certainly can't be understood in the context of a social media app. Don't use "identificator" (identifier", because it's different from the username. social-app/src/locale/locales/ro/messages.po Lines 359 to 360 in f2163c4
Also modify the Romanian strings where you use 'username' with the proper Romanian equivalent as mentioned above, such as: social-app/src/locale/locales/ro/messages.po Lines 1280 to 1281 in f2163c4
which becomes "Schimbă numele de utilizator" -- This refers to following every user / person in a starter pack. "urmărești pe toată lumea" is the correct expression. social-app/src/locale/locales/ro/messages.po Lines 712 to 714 in f2163c4
-- Small typos like these, use "a" instead of "ă" when it's this form. social-app/src/locale/locales/ro/messages.po Lines 781 to 782 in f2163c4
-- It's not the literal app password. It's similar to the App Passwords feature in Google accounts, it's a password for an app, not a password to unlock the current app, I got this one wrong as well. The correct form would be "Parolă pentru aplicații". social-app/src/locale/locales/ro/messages.po Lines 784 to 786 in f2163c4
-- Use the modern "schiță" instead of "ciornă" for drafts. social-app/src/locale/locales/ro/messages.po Lines 904 to 906 in f2163c4
-- This is an action to block the list, not to view the list of blocked accounts. I'm certain of this because earlier in the src/view/screens/ProfileList.tsx there's the action to un-mute and un-block a list:
social-app/src/locale/locales/ro/messages.po Lines 1017 to 1019 in f2163c4
So the correct translation would be "Blochează lista" and "Pune pe mut lista" -- "fain" is regional. Consider using something modern like "bine" or even "cool". social-app/src/locale/locales/ro/messages.po Lines 1080 to 1081 in f2163c4
-- Use "estompează" (imaginea), because we have a Romanian equivalent to the English "blur". social-app/src/locale/locales/ro/messages.po Lines 1092 to 1093 in f2163c4
-- "Termenii de Serviciu" is wrong, use "Termenii și condițiile" (as in Terms & Conditions) or "Termenii Serviciului" (used less often, however). social-app/src/locale/locales/ro/messages.po Lines 1154 to 1155 in f2163c4
-- Use "adresa web" (web address) or "site web" (website) instead of "domeniu" (domain), because it has a different literal meaning (property, sector, value interval, but not related to the Web). social-app/src/locale/locales/ro/messages.po Lines 1347 to 1348 in f2163c4
-- Use "Apăsați" instead of "click", there's a Romanian equivalent. social-app/src/locale/locales/ro/messages.po Lines 1399 to 1400 in f2163c4
-- Use "fereastra" instead of "dialogul". The Romanian definition for dialog is different from what it's supposed to mean in this context, which is a new web page, popup, or window. social-app/src/locale/locales/ro/messages.po Lines 1449 to 1450 in f2163c4
-- Use "meniul de subsol" instead of "footer-ul de navigare". social-app/src/locale/locales/ro/messages.po Lines 1477 to 1478 in f2163c4
-- Use "copertă" instead of "antet", antet is usually linked to e-mails and web page components, this is more akin to a cover / banner image. Also use "galerie" instead of "vizualizator de imagini", it's much more simple. social-app/src/locale/locales/ro/messages.po Lines 1498 to 1499 in f2163c4
-- Use "Regulile comunității" instead of "Ghiduri ale comunității" social-app/src/locale/locales/ro/messages.po Lines 1525 to 1526 in f2163c4
-- Stick to either "compresie" or "comprimare", for consistency. social-app/src/locale/locales/ro/messages.po Lines 687 to 688 in f2163c4
social-app/src/locale/locales/ro/messages.po Lines 1549 to 1550 in f2163c4
-- Typo, use "Versiunea de compilare": social-app/src/locale/locales/ro/messages.po Line 1694 in f2163c4
-- Use "Politica drepturilor de autor": social-app/src/locale/locales/ro/messages.po Line 1780 in f2163c4
-- Use "Scădeți luminozitatea" or "(Mod) luminozitate scăzută": social-app/src/locale/locales/ro/messages.po Lines 2067 to 2069 in f2163c4
-- Use "Trage imagini aici" instead. The current version suggests that the user should 'throw' something, when it's supposed to imply that the user can drag files over to the text input: social-app/src/locale/locales/ro/messages.po Lines 2248 to 2249 in f2163c4
-- Use "ex:" instead, it's much more shorter. social-app/src/locale/locales/ro/messages.po Line 2257 in f2163c4
-- Use "2FA prin email" instead. social-app/src/locale/locales/ro/messages.po Lines 2408 to 2414 in f2163c4
-- These are all of the big things that I've noticed so far from a look through the file. There are, of course, still instances where you address the user incorrectly, there are some minor typos and words that use the wrong conjugation, I'm sure you can fix that easily enough. And finally, of course, update the file to the latest version, they did add a lot more strings recently, some of which I've translated, which can be seen from line 9239 onward. |
Hi, @alextecplayz Nice to work together on this:
Well, I had the same dilemma initially. But thinking on this more, I came to this idea: This is a social media tool and I think a more colloquial, familiar wording is better. "Dumneavoastră" is too ceremoniously. I see more appropriate a direct addressing. Also the "Dvs." abbreviation should be avoided anywhere (I know it's widely used but it's incorrect)
I would say we should stick one way or another but not both. Keep in mind that English has only one variant, they don't have this issue. |
If you like to contribute to this branch, I can give you permissions to my fork. Just let me know. |
Figured as much, we should stick to the informal language for this, then.
Sure, I'd love to help! |
Sent invite |
My commit should update it with both my changes and to update it to the latest strings. It should be pretty complete, but there's a few new strings (commented and uncommented) that I've yet to localize. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution and I'm sorry that I didn't had time to update the PR. I've passed through whole file and everything looks good. I've only spotted few untranslated strings
src/locale/locales/ro/messages.po
Outdated
#: src/screens/StarterPack/Wizard/index.tsx:528 | ||
#: src/screens/StarterPack/Wizard/index.tsx:525 | ||
msgctxt "feeds" | ||
msgid "<0>{0}, </0><1>{1}, </1>and {2, plural, one {# other} other {# others}} are included in your starter pack" | ||
msgstr "<0>{0}, </0><1>{1}, </1>și {2, plural, one {un alt flux} few {alte # fluxuri} other {alte # de fluxuri}} sunt incluse în pachetul tău de start" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same: untranslated
src/locale/locales/ro/messages.po
Outdated
msgctxt "profiles" | ||
msgid "<0>{0}, </0><1>{1}, </1>and {2, plural, one {# other} other {# others}} are included in your starter pack" | ||
msgstr "<0>{0}, </0><1>{1}, </1>și {2, plural, one {un alt utilizator} few {alți # utilizatori} other {alți # de utilizatori}} sunt incluși în pachetul tău de start" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a suppressed translation but it seems the translation has been removed
src/locale/locales/ro/messages.po
Outdated
#: src/view/com/util/post-embeds/VideoEmbedInner/VideoEmbedInnerWeb.tsx:57 | ||
msgid "Embedded video player" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untranslated
src/locale/locales/ro/messages.po
Outdated
#: src/view/com/util/post-embeds/VideoEmbedInner/web-controls/VideoControls.tsx:405 | ||
msgid "Enter fullscreen" | ||
msgstr "" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untranslated
src/locale/locales/ro/messages.po
Outdated
#: src/view/com/notifications/FeedItem.tsx:600 | ||
msgctxt "action" | ||
msgid "Hide" | ||
msgstr "Ascunde" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation
src/locale/locales/ro/messages.po
Outdated
#: src/view/com/composer/Composer.tsx:915 | ||
#: src/view/com/composer/Composer.tsx:933 | ||
msgctxt "action" | ||
msgid "Reply" | ||
msgstr "Răspunde" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untranslated
src/locale/locales/ro/messages.po
Outdated
#: src/view/com/post/Post.tsx:204 | ||
#: src/view/com/posts/FeedItem.tsx:553 | ||
msgctxt "description" | ||
msgid "Reply to <0><1/></0>" | ||
msgstr "Răspunde la <0><1/></0>" | ||
msgstr "" | ||
|
||
#: src/view/com/posts/FeedItem.tsx:544 | ||
msgctxt "description" | ||
msgid "Reply to a blocked post" | ||
msgstr "Răspunde la o postare blocată" | ||
msgstr "" | ||
|
||
#: src/view/com/posts/FeedItem.tsx:546 | ||
msgctxt "description" | ||
msgid "Reply to a post" | ||
msgstr "Răspunde la o postare" | ||
msgstr "" | ||
|
||
#: src/view/com/post/Post.tsx:202 | ||
#: src/view/com/posts/FeedItem.tsx:550 | ||
msgctxt "description" | ||
msgid "Reply to you" | ||
msgstr "Răspunde la tine" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Four entries untranslated
src/locale/locales/ro/messages.po
Outdated
#: src/view/com/util/error/ErrorScreen.tsx:83 | ||
#: src/view/com/util/error/ErrorScreen.tsx:82 | ||
msgctxt "action" | ||
msgid "Try again" | ||
msgstr "Încearcă din nou" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untranslated
src/locale/locales/ro/messages.po
Outdated
#: src/screens/Profile/Header/ProfileHeaderStandard.tsx:202 | ||
msgctxt "action" | ||
msgid "Unblock" | ||
msgstr "Deblochează" | ||
msgstr "" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untranslated
src/locale/locales/ro/messages.po
Outdated
@@ -8,19 +8,19 @@ msgstr "" | |||
"Language: ro\n" | |||
"Project-Id-Version: \n" | |||
"Report-Msgid-Bugs-To: \n" | |||
"PO-Revision-Date: \n" | |||
"PO-Revision-Date: 2024-11-28 21:20+0000\n" | |||
"Last-Translator: \n" | |||
"Language-Team: claudiucristea.ro\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add your handle
No worries! I'll try to localize the remaining strings shortly. |
I've also updated the glossary according to the suggestions made by @alextecplayz |
Would it be possible to add one more change to this PR to enable the Romanian localization? If you could add an Lines 111 to 112 in 5f4a0f2
This will enable Romanian to be displayed as a supported language in the App Store listing, and it will also allow the |
@surfdude29, fixed. Thanks @alextecplayz, regenerated & finished the untranslated. Could you, please, review? Also, could you, please, add your handle in the .po header. Thanks |
@surfdude29 the Romanian localization has been worked by two native Romanian speakers (@alextecplayz and me) and we've cross-reviewed each other's work. This is ready for BSky developers review |
@claudiu-cristea Fantastic, then it looks like it's ready for @pfrazee to review and hopefully merge when he next cuts a release 🚀 |
Co-authored-by: surfdude29 <[email protected]>
@surfdude29 @pfrazee, thank you. Any perspective with this to be merged? I'm only worried about having to follow on main branch changes and new strings coming. I prefer we create new PRs when original strings are added/changed |
@claudiu-cristea Only @/pfrazee will know for sure, but @/gaearon said in #7136 "... just before the release ...", it's been about three weeks since the 1.95 release was cut, and I'm guessing the team want to cut a final release of 2024 before the holidays, so... maybe in the next few days? 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed the time has come!
Thank you so much everybody!
This PR provides the Romanian localization
Glossary
Some term localizations still need discussion.EDIT: All glossary terms were discussed and we've agreed to this list