-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Greek Language ('el') Support and Internationalization #6677
base: main
Are you sure you want to change the base?
Conversation
Amazing. Are there any native greek speakers available to review this? |
@pfrazee I can help with that. Should we ensure all things are translated on this PR or can it be split in smaller PRs? |
I think it's beneficial to have a good start for a first translation PR, so it would be best to continue improving this PR until it's ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inline comments for changes or additions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some comments to begin with. Let me know what you think about them.
Everyone here is amazing -- for the initial translation and the review. I'm going to let this keep cooking because it looks like not everything is resolved yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Έκανα πάλι ένα πέρασμα.
Προτείνω όπου starter pack => πακέτο έναρξης
.
Για τα feeds μάλλον τείνω προς ροές
.
Κάτι που με προβληματίζει λίγο είναι η συμπεριληπτικότητα σε κάποια σημεία, π.χ. έχω προτείνει "Θέλετε σίγουρα...;αντί για
Είστε σίγουροι...;`. Ας το σκεφτούμε.
Would it be possible to add one more change to this PR to enable the Greek localization? If you could add an Lines 101 to 102 in 770eeb5
This will enable Greek to be displayed as a supported language in the App Store listing, and it will also allow the |
Added! |
@ipinak @dpkgme @bekatoros @stergioc I don't know if I am forgetting something. I am doing a last pass of the messages.po, to see if it's missing something and I will push the commit. |
I'm not seeing |
@imertz I agree with what you said. |
…slation from the reviewers' comments
I did a last check on the messages.po. |
Co-authored-by: surfdude29 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting!! Thanks so much everybody!
case AppLanguage.el: { | ||
i18n.loadAndActivate({locale, messages: messagesEl}) | ||
await Promise.all([ | ||
import('@formatjs/intl-datetimeformat/locale-data/el'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds full internationalization support for the Greek language, using the ISO 639-1 language code 'el'.