Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Greek Language ('el') Support and Internationalization #6677

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

imertz
Copy link

@imertz imertz commented Nov 23, 2024

This PR adds full internationalization support for the Greek language, using the ISO 639-1 language code 'el'.

@pfrazee
Copy link
Collaborator

pfrazee commented Nov 23, 2024

Amazing. Are there any native greek speakers available to review this?

@ipinak
Copy link

ipinak commented Nov 24, 2024

@pfrazee I can help with that. Should we ensure all things are translated on this PR or can it be split in smaller PRs?

@auroursa
Copy link
Contributor

@pfrazee I can help with that. Should we ensure all things are translated on this PR or can it be split in smaller PRs?

I think it's beneficial to have a good start for a first translation PR, so it would be best to continue improving this PR until it's ready to be merged.

Copy link

@bekatoros bekatoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline comments for changes or additions.

src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
Copy link

@ipinak ipinak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some comments to begin with. Let me know what you think about them.

src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
@pfrazee
Copy link
Collaborator

pfrazee commented Nov 27, 2024

Everyone here is amazing -- for the initial translation and the review. I'm going to let this keep cooking because it looks like not everything is resolved yet.

Copy link

@dpkgme dpkgme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Έκανα πάλι ένα πέρασμα.
Προτείνω όπου starter pack => πακέτο έναρξης.
Για τα feeds μάλλον τείνω προς ροές.
Κάτι που με προβληματίζει λίγο είναι η συμπεριληπτικότητα σε κάποια σημεία, π.χ. έχω προτείνει "Θέλετε σίγουρα...;αντί γιαΕίστε σίγουροι...;`. Ας το σκεφτούμε.

src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
@surfdude29
Copy link
Contributor

surfdude29 commented Dec 2, 2024

Would it be possible to add one more change to this PR to enable the Greek localization? If you could add an 'el', entry to app.config.js here please, that would be great:

social-app/app.config.js

Lines 101 to 102 in 770eeb5

'de',
'es',

This will enable Greek to be displayed as a supported language in the App Store listing, and it will also allow the TextInput context menus to be translated into Greek for iOS users who have this set as their device language :)

@imertz
Copy link
Author

imertz commented Dec 12, 2024

Would it be possible to add one more change to this PR to enable the Greek localization? If you could add an 'el', entry to app.config.js here please, that would be great:

social-app/app.config.js

Lines 101 to 102 in 770eeb5

'de',
'es',

This will enable Greek to be displayed as a supported language in the App Store listing, and it will also allow the TextInput context menus to be translated into Greek for iOS users who have this set as their device language :)

Added!

@imertz
Copy link
Author

imertz commented Dec 12, 2024

@ipinak @dpkgme @bekatoros @stergioc
Thank you so much for your comments and help.
Some notes:
I believe it's best to go for "Starter Pack" and not "πακέτο έναρξης", as the greek users are accustomed (I believe) to the meaning of Starter Pack and also this is the way it is used in their conversations in BlueSky.
Also:
feed: ροή
like: Μου αρέσει

I don't know if I am forgetting something.

I am doing a last pass of the messages.po, to see if it's missing something and I will push the commit.

@surfdude29
Copy link
Contributor

Would it be possible to add one more change to this PR to enable the Greek localization? If you could add an 'el', entry to app.config.js here please, that would be great:

social-app/app.config.js

Lines 101 to 102 in 770eeb5

'de',
'es',

This will enable Greek to be displayed as a supported language in the App Store listing, and it will also allow the TextInput context menus to be translated into Greek for iOS users who have this set as their device language :)

Added!

I'm not seeing app.config.js here, maybe there was a problem pushing the commit? 🤔

@ipinak
Copy link

ipinak commented Dec 13, 2024

@ipinak @dpkgme @bekatoros @stergioc Thank you so much for your comments and help. Some notes: I believe it's best to go for "Starter Pack" and not "πακέτο έναρξης", as the greek users are accustomed (I believe) to the meaning of Starter Pack and also this is the way it is used in their conversations in BlueSky. Also: feed: ροή like: Μου αρέσει

I don't know if I am forgetting something.

I am doing a last pass of the messages.po, to see if it's missing something and I will push the commit.

@imertz I agree with what you said.

@imertz
Copy link
Author

imertz commented Dec 13, 2024

Would it be possible to add one more change to this PR to enable the Greek localization? If you could add an 'el', entry to app.config.js here please, that would be great:

social-app/app.config.js

Lines 101 to 102 in 770eeb5

'de',
'es',

This will enable Greek to be displayed as a supported language in the App Store listing, and it will also allow the TextInput context menus to be translated into Greek for iOS users who have this set as their device language :)

Added!

I'm not seeing app.config.js here, maybe there was a problem pushing the commit? 🤔

I did a last check on the messages.po.
Commited and pushed!

Co-authored-by: surfdude29 <[email protected]>
Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!! Thanks so much everybody!

case AppLanguage.el: {
i18n.loadAndActivate({locale, messages: messagesEl})
await Promise.all([
import('@formatjs/intl-datetimeformat/locale-data/el'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import('@formatjs/intl-datetimeformat/locale-data/el'),

Following #6742 being reverted in #7196, this line should be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants