Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELI5] change sign in to create account #6931

Merged
merged 3 commits into from
Jan 8, 2025
Merged

[ELI5] change sign in to create account #6931

merged 3 commits into from
Jan 8, 2025

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Dec 3, 2024 •
edited
Loading

Also ALF'd some buttons

Screenshot 2024-12-03 at 21 29 45 Screenshot 2024-12-03 at 21 29 58

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Old size New size Diff
6.86 MB 6.86 MB -121 B (-0.00%)

estrattonbailey
estrattonbailey approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can save translators effort, should do that. But if we think this is more clear and can't avoid new translations, then that's a tradeoff we can take.

src/view/shell/NavSignupCard.tsx Show resolved Hide resolved
@mozzius mozzius force-pushed the samuel/eli5-create-acc branch from 88d55c4 to a382845 Compare January 8, 2025 19:32
@arcalinea arcalinea temporarily deployed to samuel/eli5-create-acc - social-app PR #6931 January 8, 2025 19:32 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/eli5-create-acc - social-app PR #6931 January 8, 2025 19:38 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/eli5-create-acc - social-app PR #6931 January 8, 2025 19:40 — with Render Destroyed
@mozzius mozzius merged commit a0393fc into main Jan 8, 2025
7 checks passed
@mozzius mozzius deleted the samuel/eli5-create-acc branch January 8, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyliu7321 emilyliu7321 emilyliu7321 approved these changes

@estrattonbailey estrattonbailey estrattonbailey approved these changes

@gaearon gaearon Awaiting requested review from gaearon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mozzius @estrattonbailey @emilyliu7321 @arcalinea