Make the pager take full width #7066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
wide-tabs - social-app PR #7066
Render
Destroyed
gaearon
requested review from
pfrazee,
estrattonbailey,
mozzius and
haileyok
|
mozzius
approved these changes
Dec 12, 2024
|
I'll get this in as is but can iterate |
|
It’s possible that the shorter length of Chinese text caused the strange width gap that appeared after this PR. Sorry for the Chinese in the screenshot, but I wanted to more cleared show this change.
|
|
Would it be desirable to remove the minimum width for Chinese characters? |
|
Worth a try, this should not cause any other issues. It seems that Korean and Hindi also have the same issue, as their words are quite short. Perhaps we should reconsider the minimum width for this layout? |
|
Maybe instead of minimum width we could do something else in styling? The intention is to avoid the line being too short when it’s just a few items, like “All” and “Mentions” making “All” very short. |
|
Fixed in #7095 |
Signez
pushed a commit
to Signez/bsky-social-app
that referenced
this pull request
Dec 26, 2024
* Wide tabs for web * Wide tabs on mobile * Tweak min for profile * Driveby border fix * Fix single tab indicator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the pager to always fill the entire screen width by spacing out the items. If there are many items (more than a screen's worth), then they are placed like before.
Easier to understand from a demo:
ios.mov
Test Plan
Try these on iOS, Android, and web.
Centered item looks a bit weird when there's a single tab but the only case of that is being solved by #7056.