Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase scrubber height if touch device #7081

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Increase scrubber height if touch device #7081

merged 2 commits into from
Dec 12, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Dec 12, 2024

Supercedes #6939

Increases scrubber height if touch device, since 18px is too small for touchscreens

@arcalinea arcalinea temporarily deployed to scrubber-height-2 - social-app PR #7081 December 12, 2024 17:30 — with Render Destroyed
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test, assume it looks the same?

Copy link

Old size New size Diff
6.77 MB 6.77 MB 6 B (0.00%)

@mozzius
Copy link
Member Author

mozzius commented Dec 12, 2024

looks a little funky on touch devices but worth the tradeoff

@mozzius mozzius merged commit 4b32b0a into main Dec 12, 2024
6 checks passed
@mozzius mozzius deleted the scrubber-height-2 branch December 12, 2024 17:42
Signez pushed a commit to Signez/bsky-social-app that referenced this pull request Dec 26, 2024
* further increase target area of scrubber

* make scrubber bigger if touch device

---------

Co-authored-by: Antonio Sarcevic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants