Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double border due to progress guide #7084

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Dec 12, 2024

Previously, the progress bar was throwing off the hideTopBorder={index === 0} condition on the top feed item because the progress guide was always getting rendered as a row (even if returning null). To fix this, a couple of things:

  • The condition for whether to show the guide has moved into where we create rows rather than in the progress guide component itself.
  • I've also removed the top border from the progress guide itself for consistency.

Test Plan

border.mov

Also check it works as expected on mobile web, tablet and desktop (where this widget is in the right pane).

@arcalinea arcalinea temporarily deployed to fix-top-border - social-app PR #7084 December 12, 2024 20:22 — with Render Destroyed
Copy link

Old size New size Diff
6.78 MB 6.78 MB 127 B (0.00%)

@estrattonbailey estrattonbailey merged commit 6e20893 into main Dec 12, 2024
6 checks passed
Signez pushed a commit to Signez/bsky-social-app that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants