Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[topics] use a screen for topics rather than search screen #7148

Closed

Conversation

haileyok
Copy link
Contributor

No description provided.

@arcalinea arcalinea temporarily deployed to hailey/add-topic-screen - social-app PR #7148 December 18, 2024 02:59 — with Render Destroyed
@haileyok haileyok changed the base branch from main to explore-page-trending-and-starterpacks December 18, 2024 02:59
@arcalinea arcalinea temporarily deployed to hailey/add-topic-screen - social-app PR #7148 December 18, 2024 03:02 — with Render Destroyed
fetchNextPage,
hasNextPage,
} = useSearchPostsQuery({
query: topic.replaceAll(' ', '+').replaceAll('%20', '+'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to decode here first too? Haven't tested just stood out to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yea lets do that

@arcalinea arcalinea temporarily deployed to hailey/add-topic-screen - social-app PR #7148 December 18, 2024 03:06 — with Render Destroyed
@haileyok haileyok changed the base branch from explore-page-trending-and-starterpacks to main December 18, 2024 03:07
@haileyok haileyok changed the base branch from main to explore-page-trending-and-starterpacks December 18, 2024 03:07
Copy link

Old size New size Diff
6.82 MB 6.82 MB -22 B (-0.00%)

Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks! Little behind base but should be fine to merge in right?

@haileyok
Copy link
Contributor Author

made another one because this was missing a push or something, but same thing otherwise.

@haileyok haileyok closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants