Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove header subtitle from list-related screens #7154

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Dec 18, 2024

Simulator Screenshot 1 Simulator Screenshot 2

@mozzius mozzius requested a review from pfrazee December 18, 2024 13:48
@arcalinea arcalinea temporarily deployed to samuel/header-subtitle-lists - social-app PR #7154 December 18, 2024 13:48 — with Render Destroyed
Copy link

github-actions bot commented Dec 18, 2024

Old size New size Diff
6.82 MB 6.82 MB 1.11 KB (0.02%)

@arcalinea arcalinea temporarily deployed to samuel/header-subtitle-lists - social-app PR #7154 December 18, 2024 17:56 — with Render Destroyed
@pfrazee
Copy link
Collaborator

pfrazee commented Dec 18, 2024

Final:

image

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pfrazee pfrazee merged commit 3481d16 into main Dec 18, 2024
6 checks passed
@pfrazee pfrazee deleted the samuel/header-subtitle-lists branch December 18, 2024 18:23
Signez pushed a commit to Signez/bsky-social-app that referenced this pull request Dec 26, 2024
* rm subtitle, add admonition

* rm top border from empty state

* Minimal approach

* Revert uneeded change

* Even more minimal

---------

Co-authored-by: Eric Bailey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants