Add reply sorting in-thread #7156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
arcalinea
temporarily deployed
to
sort-replies - social-app PR #7156
Render
Destroyed
|
Pushed tree view setting as well. 
|
arcalinea
temporarily deployed
to
sort-replies - social-app PR #7156
Render
Destroyed
gaearon
force-pushed
the
sort-replies
branch
from
03fa908 to
6a43777
Compare
arcalinea
temporarily deployed
to
sort-replies - social-app PR #7156
Render
Destroyed
arcalinea
temporarily deployed
to
sort-replies - social-app PR #7156
Render
Destroyed
arcalinea
temporarily deployed
to
sort-replies - social-app PR #7156
Render
Destroyed
arcalinea
temporarily deployed
to
sort-replies - social-app PR #7156
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the header is always visible on all platforms, it seems like a nice place to put the sorting options.
The behavior is not perfect (e.g. it's a bit slower than I would have liked) but seems like we can ship and iterate.
Test Plan
ios.mov
web.mov