Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better list empty state #7157

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Better list empty state #7157

merged 4 commits into from
Dec 18, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Dec 18, 2024

Moves add button into the empty state itself

Before

Simulator Screenshot 1 Simulator Screenshot 2 Simulator Screenshot 3

After

Simulator Screenshot 1 Simulator Screenshot 2 Simulator Screenshot 3

Copy link

github-actions bot commented Dec 18, 2024

Old size New size Diff
6.82 MB 6.82 MB 520 B (0.01%)

@pfrazee
Copy link
Collaborator

pfrazee commented Dec 18, 2024

Tweaked the "Add" button, not amazing but I think it improves the visual balance

Mobile Web
CleanShot 2024-12-18 at 10 36 41@2x CleanShot 2024-12-18 at 10 34 03@2x

@pfrazee
Copy link
Collaborator

pfrazee commented Dec 18, 2024

Didn't like it enough, tweaked further. Isn't amazing but it's passable

Mobile Web
CleanShot 2024-12-18 at 10 45 24@2x CleanShot 2024-12-18 at 10 45 49@2x

@arcalinea arcalinea temporarily deployed to samuel/list-empty-state - social-app PR #7157 December 18, 2024 18:47 — with Render Destroyed
@mozzius mozzius force-pushed the samuel/list-empty-state branch from 2cef551 to 8409114 Compare December 18, 2024 18:59
@arcalinea arcalinea temporarily deployed to samuel/list-empty-state - social-app PR #7157 December 18, 2024 18:59 — with Render Destroyed
@pfrazee pfrazee merged commit 05c43ed into main Dec 18, 2024
6 checks passed
@pfrazee pfrazee deleted the samuel/list-empty-state branch December 18, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants