Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date time format fix #7195

Closed
wants to merge 2 commits into from
Closed

Date time format fix #7195

wants to merge 2 commits into from

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Dec 19, 2024

DMs were showing as being sent at UTC instead of the user's local time zone on iOS and Android. This seems to have been introduced in #6742.

This new polyfill should allow us to specify a default timezone on app load, but this does not appear to work on iOS or Android. See first commit for that attempt.

In the second commit, I applied the "fix", which is to use the built-in Intl.DateTimeFormat instead of the polyfill. I have not yet confirmed if this regresses #6742.

@arcalinea arcalinea temporarily deployed to date-time-format-fix - social-app PR #7195 December 19, 2024 21:40 — with Render Destroyed
Copy link

Old size New size Diff
6.84 MB 6.84 MB 0 B (0.00%)

@gaearon
Copy link
Collaborator

gaearon commented Dec 19, 2024

did this in #7196

@gaearon gaearon closed this Dec 19, 2024
@surfdude29
Copy link
Contributor

@auroursa
Copy link
Contributor

I faced a timezone issue while exploring #6742. This was my solution at the time (I hope this helps). Since no longer relied on datetimeformat to output time, I thought it was no longer an issue and removed it. I sincerely apologize for the consequences of not testing it thoroughly.

@auroursa
Copy link
Contributor

Upon rechecking the first commit, it seems that it was just missing import '@formatjs/intl-datetimeformat/add-all-tz.js', adding it will make it work properly.
image

@auroursa
Copy link
Contributor

According to the first commit, the missing import has been added. Please see #7204.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants