Change copy link icons from ArrowOutOfBox to Link

[ConnorBstill]

Changes share icons to match their actual functionality.

Brought up by this issue: #7125

The icon comes from https://iconmonstr.com/link-2-svg/, hopefully that's okay.

[heikadog]

i think what the issue was asking for was the arrowoutofbox on the first icon to stay the same but the copy link icon to be a paperclip?

also the icon is too big

[ConnorBstill]

i think what the issue was asking for was the arrowoutofbox on the first icon to stay the same but the copy link icon to be a paperclip?

also the icon is too big

Yeah you're right it is a little big, I don't see where they said anything about a paperclip though

[ConnorBstill]

Slightly smaller

[mozzius]

I like this! a couple things:

1. Can we keep this to web-only. ArrowOutOfBox is still better for native imo
2. There's several other menus were this needs to be done - sharing a feed or a list for example
3. Can we not do it for the PostCtrls? I think it works best just in the menus. I'll be changing how the PostCtrls one works soon anyway

[ConnorBstill]

@mozzius Sounds good, thanks for the feedback! Just to be completely sure, the components are all shared between web and native correct? So all I need to do is use isWeb?

Edit: nevermind I think I got it

[ConnorBstill]

Added to other menus where I could find usage of ArrowOutOfBox_Stroke2_Corner0_Rounded except for in src/screens/Topic and src/screens/Hashtag which seem to me like just mobile layout screens. Let me know if I missed something

[ConnorBstill]

@mozzius I missed the list share icon (which you mentioned, oops), here's what that looks like with a link icon:

The icons that the NativeDropdown component uses look different (and worse imo) than the ones in the other menus, so if we want these to be consistent then I think NativeDropdown needs to be refactored, or its usage replaced with the other Menu component. Maybe it needs to stay the way it is for some reason unknown to me, but if it's something we want to change I can try to take that on in another issue/PR since it might be out of scope for this one.