Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply avatar moderation to quote post #7229

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Dec 20, 2024

Avatars in quote posts are not blurred according to moderation.

The avatarModeration was introduced in #2325. Later the more general moderation attribute was introduced in #2550, which makes avatarModeration obsolete.

Fixes #7117.

@gaearon
Copy link
Collaborator

gaearon commented Dec 20, 2024

I don't get it. Why aren't they equivalent? What is the source of divergence between the two calculations?

@gaearon
Copy link
Collaborator

gaearon commented Dec 20, 2024

OK I got it, the issue isn't them being different, it's the old prop being optional (and not specified in a bunch of contexts). Makes sense.

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

@gaearon gaearon merged commit fa2072c into bluesky-social:main Dec 20, 2024
@c960657 c960657 deleted the avatar-moderation branch December 21, 2024 08:45
Signez pushed a commit to Signez/bsky-social-app that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatars of users labelled for adult profile content aren't blurred in quotes
2 participants