Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bookmark icons #7231

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

danielbayley
Copy link

…for the upcoming possible bookmarks feature. This is to aid the work in progress by @ebwinters, as noted here: bluesky-social/atproto#2000 (comment).

@ebwinters
Copy link

Do you have a picture of what these will look like

@danielbayley
Copy link
Author

Do you have a picture of what these will look like

You can preview them directly on here… They match the other icons precisely, and already optimised (although the whole set is not exactly properly optimised currently…) or, did you mean a full mock-up? @ebwinters

@danielbayley
Copy link
Author

danielbayley commented Dec 21, 2024

Do you have a picture of what these will look like

@ebwinters Something like these? (Quickly knocked up from screenshots…)

IMG_0146
IMG_0147

Copy link

@ebwinters ebwinters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I'm not a contrib, can't approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants