Fix dialogs not responding to changes in content height #7413
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dialogs were updating state that changed the native module's props, then immediately triggering an imperative function. I believe this was causing race conditions, with the update function being called before the new state had the chance to render. We simply add a timeout to delay the function call until after the component renders
This improves iOS, but doesn't seem to have helped much with Android - that just seems equally janky as before. Longer timeouts don't work either, so I'm thinking there's some deeper problem at play
Before
Simulator.Screen.Recording.-.iPhone.16.-.2025-01-09.at.17.42.40.mp4
After
Simulator.Screen.Recording.-.iPhone.16.-.2025-01-09.at.17.42.09.mp4