Add CONVERT_COORD_TO_JAGCOORD setting
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds `IdentifiedChildProperty` as a base class for identified entity properties. - Each `IdentifiedChildProperty` has its own `formattedValue` function, which takes in a `SettingSet` and `SymbolDictionary` to allow for flexibility and future maintainability. - Replaces the old `PropertyFormatterCollection` npc property formatters. - Adds a `NopSettingSet` and `NopSymbolDictionary` to maintain consistency with the old `value` property each of these new `IdentifiedChildProperty`s previously had. These nop variants are not used anywhere outside the `value` assignment. - Adds the `Setting.CONVERT_COORD_TO_JAGCOORD` set to disabled by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Adds
IdentifiedChildPropertyas a base class for identified entity properties.Each
IdentifiedChildPropertyhas its ownformattedValuefunction, which takes in aSettingSetandSymbolDictionaryto allow for flexibility and future maintainability.Replaces the old
PropertyFormatterCollectionnpc property formatters.Adds a
NopSettingSetandNopSymbolDictionaryto maintain consistency with the oldvalueproperty each of these newIdentifiedChildPropertys previously had. These nop variants are not used anywhere outside thevalueassignment.Adds the
Setting.CONVERT_COORD_TO_JAGCOORDset to disabled by default.