Made ArrayVec::new and ArrayString::new const fns #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added utils module with a `MaybeUninit` helper type to construct `[MaybeUninit<T>; N]` Removed all uses of the "unstable-const-fn" feature, and documented it as being deprecated. Changed `assert_capacity_limit` macro to work in const contexts.
Updated the capacity panic test
|
Nice, thanks! Instead of commenting, I just pushed a tweak to the formatting and wording for the feature flag. Thanks for remembering to update that. |
|
I considered this, as a follow-up to your solution: [(); u32::MAX as usize /*ArrayVec: largest supported capacity is u32::MAX*/][$cap]It also seems to work, but here I'd be worried about compiler quirks that would give problems for such a big array (even if it has 0 size in memory), for example in debuggers. |
|
I have the same concern with instantiating long zero-sized arrays. For example, if this ever happens again: rust-lang/rust#68010 |
bluss
approved these changes
Mar 28, 2021
|
Thanks. It's quite valuable for us to get off nightly features, even if the usage was very limited here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to this comment: #93 (comment)
Fixes #93