-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example document #43
Conversation
Reviewer's Guide by SourceryThis pull request updates the documentation for the No sequence diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bluzky - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
<.radio_group name="question-1" value="option-2"> | ||
<div class="flex items-center space-x-2"> | ||
<.radio_group_item builder={builder} value="option-one" id="option-one"></.radio_group_item> | ||
<.label for="option-one"> | ||
Option One | ||
</.label> | ||
</div> | ||
<div class="flex items-center space-x-2"> | ||
<.radio_group_item builder={builder} value="option-two" id="option-two"></.radio_group_item> | ||
<.label for="option-two"> | ||
Option Two | ||
</.label> | ||
</div> | ||
</.radio_group> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider restructuring the example for better clarity and completeness.
This could include showing how the builder
parameter is obtained or passed to the radio_group_item
component, which would make the example more complete and easier to understand for users of this module.
<.radio_group name="question-1" value="option-2">
<%= for {option, label} <- [{"option-one", "Option One"}, {"option-two", "Option Two"}] do %>
<div class="flex items-center space-x-2">
<.radio_group_item builder={@form} value={option} id={option} />
<.label for={option}><%= label %></.label>
</div>
<% end %>
</.radio_group>
Summary by Sourcery
Enhance the documentation of the RadioGroup component by adding an example usage section.
Documentation: