Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tab doc typo, bad link and indentation #92

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

pierrelegall
Copy link
Contributor

@pierrelegall pierrelegall commented Nov 27, 2024

Summary by Sourcery

Fix documentation issues in the SaladUI.Tabs module by correcting a link and improving code indentation.

Bug Fixes:

  • Correct the documentation link for the tabs component in the SaladUI.Tabs module.
  • Fix indentation issues in the example code within the SaladUI.Tabs module documentation.

Copy link

sourcery-ai bot commented Nov 27, 2024

Reviewer's Guide by Sourcery

This PR fixes documentation and formatting issues in the tabs component. The changes include correcting a typo in the module documentation, updating an incorrect link reference, and improving code indentation in the example code.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Fixed documentation header and link reference
  • Corrected typo from 'Implement' to 'Implementation'
  • Updated incorrect link reference from 'card' to 'tabs'
lib/salad_ui/tabs.ex
Improved code example formatting
  • Fixed inconsistent indentation in the example code block
  • Aligned nested components properly
lib/salad_ui/tabs.ex

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pierrelegall - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@bluzky bluzky merged commit 71acc20 into bluzky:main Nov 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants