forked from nodejs/node
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Resolve hook prototype #1
Open
guybedford
wants to merge
8
commits into
bmeck:initial-pr
Choose a base branch
from
guybedford:resolve-hook
base: initial-pr
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Aug 31, 2017
-
module: Allow runMain to be ESM
This follows the EPS an allows the node CLI to have ESM as an entry point. `node ./example.mjs`. A newer V8 is needed for `import()` so that is not included. `import.meta` is still in specification stage so that also is not included. Author: Bradley Farias <[email protected]> Author: Guy Bedford <[email protected]> Author: Jan Krems <[email protected]> fix eslint errors add missing include restore module.exports remove TryCatch Use anonymous namespace, fix compilation warnings Clean up string usage Fix c++ linting Allow unlinked cwd Fixes make test. fix indentation eslint fix more common whitespace usage, fix missing header include try to address Windows build failure throw no-base error in JS No need to go to C++ for this. Fix resolve module dir URL Fix module.load usage Makes CJS module loading work process.exit(1) when there is an error in ESM loading Add support for .mjs in test harness tools: support ESM in ESLint required-modules rule Start porting ESM tests Disable required-modules for basic mjs tests Avoid using auto for easy-to-mix up cases fix linter errors for new linter rules on `master` More linting use null as [[Prototype]] directly move src/loader/* out of its own directory fix more linting properly decode url encoding in pathnames Cleanup URL->file path conversion Error cases, add tests. lint fix module._cache regression move test out of fixtures nits on test properly realpath after getting path from URL reject module instantiation when binding throws call e.stack getter preserve-symlinks support remove unnecessary index file flag as harmony-modules lint ordering of lists add .mjs to coverage, ESM support appears buggy though simple ESM namespace keys test move logic for making URL from file path f test and fix snapshot timing of CJS use internal/errors fix bug with moduleProvider in CJS snapshot nits from @Fishrock123 linting gate
Configuration menu - View commit details
-
Copy full SHA for 1942cc8 - Browse repository at this point
Copy the full SHA 1942cc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 918e936 - Browse repository at this point
Copy the full SHA 918e936View commit details -
Configuration menu - View commit details
-
Copy full SHA for 118d18a - Browse repository at this point
Copy the full SHA 118d18aView commit details
Commits on Sep 1, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 762cf03 - Browse repository at this point
Copy the full SHA 762cf03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1adf7cb - Browse repository at this point
Copy the full SHA 1adf7cbView commit details
Commits on Sep 3, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 6e328d0 - Browse repository at this point
Copy the full SHA 6e328d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5496f77 - Browse repository at this point
Copy the full SHA 5496f77View commit details
Commits on Sep 5, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 31aa66f - Browse repository at this point
Copy the full SHA 31aa66fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.