-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fixes dependencies in metapackage when building wheel file (#110)
using `python3 -m build` will first build the sdist (tar.gz file) and then use that package it to build a .whl file. In this process it is not possible to [glob](https://github.com/bmw-software-engineering/lobster/blob/981b2f5e5ecbe89feaeffe38eb2f3c9b1dc6ae41/packages/lobster-metapackage/setup.py#L40) all other tools as dependencies anymore, because they are not available in the sdist package since we are using `from lobster import version` in the setup.py files anyway, we need to have module lobster available in order to build the tools from sdist (tar.gz file). You cannot build the tool from source solely by using tar.gz file because of that. This is contrary to the purpose of sdist. Suggestion: Get rid of sdist, don't build and don't provide it on pypi (don't upload it) -> this is consistent to TRLC We will only provide .whl files Therefore we can use `python3 -m build --wheel` explicitly to build .whl files from the source code instead of the previous build sdist package
- Loading branch information
1 parent
981b2f5
commit 874e475
Showing
14 changed files
with
17 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,8 +3,9 @@ | |
## Changelog | ||
|
||
|
||
### 1.0.0-dev | ||
### 0.9.19-dev | ||
|
||
* Fixes packaging of `bmw-lobster`. | ||
|
||
### 0.9.18 | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
package: | ||
@python3 -m build | ||
@python3 -m build --wheel |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
package: | ||
rm -rf lobster dist meta_dist | ||
cp -Rv $(LOBSTER_ROOT)/lobster lobster | ||
@python3 -m build | ||
@python3 -m build --wheel | ||
mv dist meta_dist |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters