Get full path of files found in rv.stdout #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NicoletaCroitoru <[email protected]>
phiwuu
requested changes
Jan 20, 2025
phiwuu
reviewed
Jan 20, 2025
| @@ -153,6 +153,7 @@ def main(): | |||
| match = re.match(RE_NOTAGS, line) | |||
| if match: | |||
| filename, line_nr, kind, function_name = match.groups() | |||
| filename = next((item for item in file_list if filename in item), None) | |||
| filename = os.path.relpath(filename, prefix) | |||
There was a problem hiding this comment.
This line filename = os.path.relpath(filename, prefix) returns the relative path, but your pull request title indicates to use the full path. What do you intend to achieve?
There was a problem hiding this comment.
Use case: some lines from rv.stdout contains relative path instead of absolute path and because of this filename = os.path.relpath(filename, prefix) will do nothing and a fix to get the absolute path is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get full path of files found in rv.stdout