Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support different schemas #79

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Support different schemas #79

merged 1 commit into from
Oct 29, 2024

Conversation

SurajBDeore
Copy link
Contributor

@SurajBDeore SurajBDeore commented Sep 25, 2024 •
edited
Loading

Add support to lobster-codebeamer to generate output using the following schemas:

  • requirement
  • implementation
  • activity

The user can select the schema with a command line flag,
or through the configuration file.

Issue: #86

@SurajBDeore SurajBDeore requested a review from a team as a code owner September 25, 2024 08:50
@mugdhadhole1
Copy link
Contributor

mugdhadhole1 commented Oct 1, 2024 •
edited
Loading

I could see, the CI has failed while executing linter.
Always make sure you run make lint locally before you make a commit and push the code

@SurajBDeore SurajBDeore force-pushed the lobster-codebeamer-support-TDS/TCS branch from fc844a7 to 61bc559 Compare October 1, 2024 12:51
@phiwuu phiwuu added lobster-codebeamer Affects codebeamer integration bug Something isn't working labels Oct 1, 2024
@SurajBDeore SurajBDeore changed the title Add support for TDS/TCS in lobster-codebeamer (Test Case/Design Speci… Support different schemas Oct 1, 2024
@SurajBDeore SurajBDeore force-pushed the lobster-codebeamer-support-TDS/TCS branch from 61bc559 to 7e56bc8 Compare October 1, 2024 13:18
@phiwuu phiwuu linked an issue Oct 10, 2024 that may be closed by this pull request
lobster-codebeamer shall support all schema types #86
Closed
phiwuu
phiwuu requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@phiwuu phiwuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please test our changes :-)

lobster/tools/codebeamer/codebeamer.py Show resolved Hide resolved
lobster/tools/codebeamer/codebeamer.py Outdated Show resolved Hide resolved
@mugdhadhole1
Copy link
Contributor

mugdhadhole1 commented Oct 16, 2024 •
edited
Loading

  1. I would really suggest to look at the linting errors. I could see make lint showed a lot of linting errors.
  2. I would also suggest you to rename the unit test file with test_<file_name>.py
    where file_name must be the name of file for which you are writing the unit tests for.

@mugdhadhole1
Copy link
Contributor

mugdhadhole1 commented Oct 16, 2024 •
edited
Loading

Currently, the command accepts both "--schema" argument as well as "--config" argument.
Hence, it creates ambiguity in fetching "schema".
Suggestion, we should either use --schema flag or schema in config file

@phiwuu
Copy link
Member

phiwuu commented Oct 17, 2024

Currently, the command accepts both "--schema" argument as well as "--config" argument. Hence, it creates ambiguity in fetching "schema". Suggestion, we should either use --schema flag or schema in config file

The same problem exists with "token" and "user name/password". Both can be given in the config and as command line arguments, see #94

Currenlty, the config file takes precedence in all cases. I recommend to use the same approach here, too.
Please add a remark into the README.md file.

@SurajBDeore SurajBDeore force-pushed the lobster-codebeamer-support-TDS/TCS branch 7 times, most recently from 59c0bad to e63423e Compare October 28, 2024 18:19
@SurajBDeore SurajBDeore force-pushed the lobster-codebeamer-support-TDS/TCS branch from e63423e to 322b464 Compare October 28, 2024 18:23
@SurajBDeore SurajBDeore reopened this Oct 28, 2024
@SurajBDeore
Copy link
Contributor Author

please test our changes :-)

Tested

@SurajBDeore SurajBDeore reopened this Oct 29, 2024
kedarnn
kedarnn previously approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@kedarnn kedarnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

mugdhadhole1
mugdhadhole1 previously approved these changes Oct 29, 2024
View reviewed changes
@mugdhadhole1 mugdhadhole1 requested a review from phiwuu October 29, 2024 08:08
@SurajBDeore SurajBDeore dismissed stale reviews from mugdhadhole1 and kedarnn via 02e3e81 October 29, 2024 08:55
@SurajBDeore SurajBDeore force-pushed the lobster-codebeamer-support-TDS/TCS branch from a688973 to 02e3e81 Compare October 29, 2024 08:55
phiwuu
phiwuu previously approved these changes Oct 29, 2024
View reviewed changes
@SurajBDeore SurajBDeore force-pushed the lobster-codebeamer-support-TDS/TCS branch from 02e3e81 to 7f38f12 Compare October 29, 2024 10:34
@SurajBDeore
Support different schemas
7a7d2e2 
Add support to `lobster-codebeamer` to generate output using the following schemas:
- requirement
- implementation
- activity

The user can select the schema with a command line flag,
or through the configuration file.

Issue: #86
@SurajBDeore SurajBDeore force-pushed the lobster-codebeamer-support-TDS/TCS branch from 7f38f12 to 7a7d2e2 Compare October 29, 2024 10:40
@phiwuu phiwuu merged commit 9231446 into main Oct 29, 2024
21 checks passed
@phiwuu phiwuu deleted the lobster-codebeamer-support-TDS/TCS branch October 29, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phiwuu phiwuu phiwuu approved these changes

@kedarnn kedarnn kedarnn left review comments

@mugdhadhole1 mugdhadhole1 mugdhadhole1 left review comments

Assignees
No one assigned
Labels
bug Something isn't working lobster-codebeamer Affects codebeamer integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lobster-codebeamer shall support all schema types
4 participants
@SurajBDeore @mugdhadhole1 @phiwuu @kedarnn