-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "or" in uplinks #91
base: main
Are you sure you want to change the base?
Support "or" in uplinks #91
Conversation
1da5628
to
6719212
Compare
This is a breaking change. I suggest we release v0.9.18 first, and then switch to v1.0.0 with this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please update the appropriate
README.md
- please update the
CHANGELOG.md
- please update https://github.com/bmw-software-engineering/lobster/blob/main/documentation/config_files.md (especially the paragraph about "requires")
d9d7c38
to
5b6c597
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running lobster-ci-report with the attached inputs, it exits with
return code 0 where it should exit with return code 1.
In attached example, there are 2 functions in python and 2 requirements in different trlc files, the tracing policy says that trace to: "Requirements1";
But one function traces to "Requirements2" so, the expectation is that lobster-ci-report treats this as an error and returns 1, but in fact it returns 0.
The reason is that, lobster-ci-report only checks if there are error messages attached to any items it does not evaluate the status, in this example the status is "PARTIAL" but the item has no message.
So, possible solutions
- lobster-ci-report does not only check the error messages but the status as well.
- lobster-report attaches a message to the item. (preferred solution)
@@ -102,13 +102,11 @@ def parse_level_declaration(self): | |||
"duplicate declaration") | |||
|
|||
item = { | |||
"name" : level_name, | |||
"kind" : level_kind, | |||
"traces" : [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, update
lobster/lobster/tools/core/html_report.py
Line 138 in f69c82b
for target in map(name_hash, level["traces"]): |
Otherwise, HTML report will not get generated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: if "dot" is not installed, then the bug will not be visible, because the tracing policy graph will not be rendered. See
lobster/lobster/tools/core/html_report.py
Lines 365 to 369 in f69c82b
if is_dot_available(dot): | |
doc.add_line('<div class="column">') | |
doc.add_heading(3, "Tracing policy") | |
create_policy_diagram(doc, report, dot) | |
doc.add_line('</div>') |
@TannazVhdBMWExt, this pull request shows no checks at all. We need to investigate the reason. Why are CI jobs not running? |
9f89137
to
ea91bb4
Compare
@TannazVhdBMWExt please rebase on main and ensure that checks are running. |
ea91bb4
to
3528538
Compare
lobster.config accepts multiline keywords which considered to be "and" the "requires" keyword has been changed to "trace from" Resolves bmw-software-engineering#10
ac10304
to
3628e79
Compare
#10