Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "or" in uplinks #91

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TannazVhdBMWExt
Copy link
Contributor

@TannazVhdBMWExt TannazVhdBMWExt commented Oct 9, 2024

#10

@TannazVhdBMWExt TannazVhdBMWExt requested a review from a team as a code owner October 9, 2024 12:00
@TannazVhdBMWExt TannazVhdBMWExt force-pushed the issue-10-support-OR-in-uplinks branch 2 times, most recently from 1da5628 to 6719212 Compare October 9, 2024 12:07
@phiwuu
Copy link
Member

phiwuu commented Oct 16, 2024

This is a breaking change. I suggest we release v0.9.18 first, and then switch to v1.0.0 with this pull request.

@phiwuu phiwuu added the lobster-core Affects core LOBSTER tools label Oct 16, 2024
@phiwuu phiwuu changed the title Issue 10 support or in uplinks support or in uplinks Oct 16, 2024
@phiwuu phiwuu changed the title support or in uplinks Issue 10 support "or" in uplinks Oct 16, 2024
Copy link
Member

@phiwuu phiwuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phiwuu phiwuu changed the title Issue 10 support "or" in uplinks Support "or" in uplinks Oct 16, 2024
@TannazVhdBMWExt TannazVhdBMWExt force-pushed the issue-10-support-OR-in-uplinks branch 2 times, most recently from d9d7c38 to 5b6c597 Compare October 17, 2024 11:21
Copy link
Contributor

@mugdhadhole1 mugdhadhole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running lobster-ci-report with the attached inputs, it exits with
return code 0 where it should exit with return code 1.

In attached example, there are 2 functions in python and 2 requirements in different trlc files, the tracing policy says that trace to: "Requirements1";
But one function traces to "Requirements2" so, the expectation is that lobster-ci-report treats this as an error and returns 1, but in fact it returns 0.
The reason is that, lobster-ci-report only checks if there are error messages attached to any items it does not evaluate the status, in this example the status is "PARTIAL" but the item has no message.
So, possible solutions

  • lobster-ci-report does not only check the error messages but the status as well.
  • lobster-report attaches a message to the item. (preferred solution)

Example.zip

@@ -102,13 +102,11 @@ def parse_level_declaration(self):
"duplicate declaration")

item = {
"name" : level_name,
"kind" : level_kind,
"traces" : [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update

for target in map(name_hash, level["traces"]):
as well
Otherwise, HTML report will not get generated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: if "dot" is not installed, then the bug will not be visible, because the tracing policy graph will not be rendered. See

if is_dot_available(dot):
doc.add_line('<div class="column">')
doc.add_heading(3, "Tracing policy")
create_policy_diagram(doc, report, dot)
doc.add_line('</div>')

@phiwuu
Copy link
Member

phiwuu commented Nov 12, 2024

@TannazVhdBMWExt, this pull request shows no checks at all. We need to investigate the reason. Why are CI jobs not running?

@TannazVhdBMWExt TannazVhdBMWExt force-pushed the issue-10-support-OR-in-uplinks branch 2 times, most recently from 9f89137 to ea91bb4 Compare November 14, 2024 14:06
@phiwuu
Copy link
Member

phiwuu commented Nov 28, 2024

@TannazVhdBMWExt please rebase on main and ensure that checks are running.

@TannazVhdBMWExt TannazVhdBMWExt force-pushed the issue-10-support-OR-in-uplinks branch from ea91bb4 to 3528538 Compare November 29, 2024 12:33
lobster.config accepts multiline keywords which considered to be "and"
the "requires" keyword has been changed to "trace from"

Resolves bmw-software-engineering#10
@TannazVhdBMWExt TannazVhdBMWExt force-pushed the issue-10-support-OR-in-uplinks branch from ac10304 to 3628e79 Compare November 29, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lobster-core Affects core LOBSTER tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants