test to become 1 commit #122
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiFerMa
force-pushed
the
utility/try_to_automate_squashing
branch
from
0f207a5 to
48c62fe
Compare
Detecting duplicated components
Add check to detect duplicated components of a record
when parsing a TRLC file.
Example:
```
Something duplicated
{
description = "This is fine!"
description = "This is the duplicate."
}
```
The behavior of the `Record_Object` class is changed such that the `assign` method only
assigns components to the record if it has not been assigned already.
This is implemented by checking if the field type is different from `Implicit_Null`.
The `Parser` class asks the `Record_Object` if the component is `Implicit_Null`.
If no, then an error is sent to the message handler.
DiFerMa
force-pushed
the
utility/try_to_automate_squashing
branch
from
03fb6a8 to
d8f23f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detecting duplicated components
Add check to detect duplicated components of a record when parsing a TRLC file.
Example:
The behavior of the
Record_Objectclass is changed such that theassignmethod only assigns components to the record if it has not been assigned already. This is implemented by checking if the field type is different fromImplicit_Null.The
Parserclass asks theRecord_Objectif the component isImplicit_Null. If no, then an error is sent to the message handler.