removes the builtin function syntax #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophkloeffel
force-pushed
the
remove/builtin-function-syntax
branch
from
c5bf249 to
4cb84e4
Compare
christophkloeffel
force-pushed
the
remove/builtin-function-syntax
branch
from
4cb84e4 to
f898b5d
Compare
florianschanda
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Nice work :)
Removing this means we need to change the major version. It also means we should kill check files at that point and possible make -I . the default as well. To be discussed...
Some comments:
lexer.py:
- You need to also remove the
:option for the identifier loop
in the lexer, as:can no longer be part of a valid name
CHANGELOG.md:
- You need an entry here as well
|
@florianschanda This PR is open for a while now. For me it is okay to step to the next major version now. Shall we merge this PR? |
|
We can, but it'd be good to bundle it with some other incompatible changes. Do you have a wishlist? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51