Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated feature: check files #74

Closed
wants to merge 16 commits into from
Closed

remove deprecated feature: check files #74

wants to merge 16 commits into from

Conversation

ankushsonare1
Copy link

No description provided.

@christophkloeffel christophkloeffel added this to the TRLC 2.0.0 milestone Mar 20, 2024
@christophkloeffel christophkloeffel linked an issue Mar 20, 2024 that may be closed by this pull request
remove deprecated feature: check files #53
Closed
@christophkloeffel christophkloeffel self-assigned this Mar 20, 2024
christophkloeffel
christophkloeffel suggested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@christophkloeffel christophkloeffel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also create a new entry in https://github.com/bmw-software-engineering/trlc/blob/main/CHANGELOG.md

trlc/trlc.py Outdated Show resolved Hide resolved
trlc/trlc.py Show resolved Hide resolved
@christophkloeffel
Copy link
Contributor

christophkloeffel commented Mar 26, 2024 •
edited
Loading

Regarding the LRM: Please also have a look at the tracing report of LOBSTER
Make sure that the new code matches the LRM

@ankushsonare1 ankushsonare1 requested a review from a team as a code owner March 28, 2024 08:17
@ankushsonare1 ankushsonare1 requested review from mugdhadhole1 and removed request for mugdhadhole1 March 28, 2024 08:24
@christophkloeffel
Copy link
Contributor

Please also create a new entry in https://github.com/bmw-software-engineering/trlc/blob/main/CHANGELOG.md

This is still pending

christophkloeffel
christophkloeffel suggested changes Mar 28, 2024
View reviewed changes
language-reference-manual/lrm.trlc Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also have a look at section 3 and adapt it accordingly

akashsurwase1
akashsurwase1 previously approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@akashsurwase1 akashsurwase1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge

@akashsurwase1
Copy link
Contributor

ok to merge

@florianschanda
Copy link
Collaborator

Obsoleted by #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mugdhadhole1 mugdhadhole1 Awaiting requested review from mugdhadhole1

@christophkloeffel christophkloeffel Awaiting requested review from christophkloeffel

@akashsurwase1 akashsurwase1 Awaiting requested review from akashsurwase1

Assignees

@christophkloeffel christophkloeffel

Labels
None yet
Projects
None yet
Milestone
TRLC 2.0.0
Development

Successfully merging this pull request may close these issues.

remove deprecated feature: check files
4 participants
@ankushsonare1 @christophkloeffel @akashsurwase1 @florianschanda