Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings regarding duplicate late declaration of packages #75

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

mugdhadhole1
Copy link
Contributor

ISSUE: #72

Copy link
Contributor

@christophkloeffel christophkloeffel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trlc/parser.py Show resolved Hide resolved
@christophkloeffel christophkloeffel self-assigned this Mar 26, 2024
@christophkloeffel christophkloeffel changed the title Remove warnings regarding duplicate late declaration of packages (#72) Remove warnings regarding duplicate late declaration of packages Mar 26, 2024
@mugdhadhole1 mugdhadhole1 force-pushed the remove/warning-message-for-packages branch from d16f3f9 to 29f6199 Compare April 5, 2024 10:12
@mugdhadhole1 mugdhadhole1 requested a review from a team as a code owner April 5, 2024 10:12
@christophkloeffel christophkloeffel enabled auto-merge (squash) April 16, 2024 11:42
Copy link
Contributor

@christophkloeffel christophkloeffel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a tracing file in "rbt-late-package-declarations" test folder. make sure to delete this, because you deleted the corresponding entry in the LRM

@mugdhadhole1 mugdhadhole1 force-pushed the remove/warning-message-for-packages branch 2 times, most recently from 149a791 to 2f801e9 Compare April 19, 2024 07:27
Copy link
Contributor

@akashsurwase1 akashsurwase1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge

ISSUE: #72

Deleted the tracing file in "rbt-late-package-declarations" test folder.
…tion of packages(Issue #72)

Updated the CHANGELOG.md file to remove the linked content in the LRM as well as removed the Duplicate Package reference from lrm.html
Github Issue: #72

Updated the CHANGELOG.md file to remove the warning message while encountering duplicate late package declarations.
@christophkloeffel christophkloeffel force-pushed the remove/warning-message-for-packages branch from 1c2da29 to 7d9a50b Compare April 24, 2024 08:29
@christophkloeffel christophkloeffel merged commit e464c13 into main Apr 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings regarding duplicate late declaration of packages are not needed
3 participants