Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation of repo map in TenantParser #105

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Conversation

felixedel
Copy link
Member

@felixedel felixedel commented Jan 5, 2024

The latest change introduced a bug that failed to parse the following
configuration snippets [1] in a tenant-config.yaml file.

This kind of configuration wasn't supported by Zubbi before, but also
didn't fail when parsing the tenant configuration file. For now,
explicitly ignore this kind of configuration.

Additionally, we also add an explicit test for the tenant parser with
a variety of project configs to catch those errors more easily.

This change also fixes the exclusion of jobs from a project, which
didn't work properly due to the usage of "jobs" instead of "job".

[1]:

  # Include nothing from projects foo, bar
  - include: []
    projects:
      - foo
      - bar

  # Exclude jobs and semaphores from foo
  - exclude:
      - job
      - semaphore
    projects:
      - foo

@felixedel felixedel requested a review from a team as a code owner January 5, 2024 09:58
The latest change introduced a bug that failed to parse the following
configuration snippets [1] in a tenant-config.yaml file.

This kind of configuration wasn't supported by Zubbi before, but also
didn't fail when parsing the tenant configuration file. For now,
explicitly ignore this kind of configuration.

Additionally, we also add an explicit test for the tenant parser with
a variety of project configs to catch those errors more easily.

This change also fixes the exclusion of jobs from a project, which
didn't work properly due to the usage of "jobs" instead of "job".

[1]:
    # Include nothing from projects foo, bar
    - include: []
      projects:
        - foo
        - bar

    # Exclude jobs and semaphores from foo
    - exclude:
        - job
        - semaphore
      projects:
        - foo
@felixedel felixedel force-pushed the fe-fix-tenant-parser branch from f6bd081 to f122320 Compare January 5, 2024 10:28
@westphahl westphahl merged commit 0429489 into master Jan 5, 2024
2 checks passed
@westphahl westphahl deleted the fe-fix-tenant-parser branch January 5, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants