Push tracing of Parlia system transactions so that live tracers can properly traces those state changes #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperly traces those state changes
zzzckck
changed the base branch from
merge_geth_v1.13.15_v1.14.11
to
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #2768 for context and details.
This introduced
OnSystemTxStart/OnSystemTxEndand renamedOnSystemTxEndtoOnSystemTxFixIntrinsicGas(soOnSystemTxEndcan be re-used for other purposes).The Parlia engine is now tracing it's system transaction properly which was not the case before.
Rationale
This PR ensure that system transactions are properly tested when using live tracers.
Changes
Consensus engine is now receiving a
tracer *tracing.Hooksthat Parlia engine then uses when needing to apply system transactions.