remove orderInfo from orderInfoForPub when publish anything (#766)

* add closed orders to ToRemoveOrderIdCh when ShouldPublishAny=true

CHANGELOG.md

@@ -1,4 +1,7 @@
 # Changelog
+## 0.7.2-hf.1
+BUG FIXES
+* [\#766](https://github.com/binance-chain/node/pull/766)[Dex] remove orderInfo from orderInfoForPub when publish anything
 
 ## 0.7.2
 BUG FIXES

app/app.go

@@ -810,6 +810,7 @@ func (app *BinanceChain) publish(tradesToPublish []*pub.Trade, proposalsToPublis
 
 	if app.metrics != nil {
 		app.metrics.CollectBlockTimeMs.Set(float64(duration))
+		app.metrics.NumOrderInfoForPublish.Set(float64(len(orderInfoForPublish)))
 	}
 
 	pub.Logger.Info("start to publish", "height", height,

app/pub/metrics.go

@@ -50,6 +50,8 @@ type Metrics struct {
 	NumAccounts metricsPkg.Gauge
 	// num of transfer
 	NumTransfers metricsPkg.Gauge
+
+	NumOrderInfoForPublish metricsPkg.Gauge
 }
 
 // PrometheusMetrics returns Metrics build using Prometheus client library.
@@ -141,5 +143,10 @@ func PrometheusMetrics() *Metrics {
 			Name:      "num_transfer",
 			Help:      "Number of transfer we published",
 		}, []string{}),
+		NumOrderInfoForPublish: prometheus.NewGaugeFrom(stdprometheus.GaugeOpts{
+			Subsystem: "publication",
+			Name:      "num_orderinfo_pub",
+			Help:      "Number of OrderInfoForPublish in orderKeeper",
+		}, []string{}),
 	}
 }

app/pub/publisher.go

@@ -56,15 +56,14 @@ func Publish(
 			var opensToPublish []*Order
 			var closedToPublish []*Order
 			var feeToPublish map[string]string
-			if cfg.PublishOrderUpdates || cfg.PublishOrderBook {
-				opensToPublish, closedToPublish, feeToPublish = collectOrdersToPublish(
-					marketData.tradesToPublish,
-					marketData.orderChanges,
-					marketData.orderInfos,
-					marketData.feeHolder,
-					marketData.timestamp)
-				addClosedOrder(closedToPublish, ToRemoveOrderIdCh)
-			}
+
+			opensToPublish, closedToPublish, feeToPublish = collectOrdersToPublish(
+				marketData.tradesToPublish,
+				marketData.orderChanges,
+				marketData.orderInfos,
+				marketData.feeHolder,
+				marketData.timestamp)
+			addClosedOrder(closedToPublish, ToRemoveOrderIdCh)
 
 			// ToRemoveOrderIdCh would be only used in production code
 			// will be nil in mock (pressure testing, local publisher) and test code

version/version.go

@@ -12,7 +12,7 @@ var (
 	Version string
 )
 
-const NodeVersion = "0.7.2"
+const NodeVersion = "0.7.2-hf.1"
 
 func init() {
 	Version = fmt.Sprintf("Binance Chain Release: %s;", NodeVersion)