Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: tune snapshot bloom for higher tps #230

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

perf: tune snapshot bloom for higher tps #230

wants to merge 2 commits into from

Conversation

bnoieh
Copy link
Contributor

@bnoieh bnoieh commented Nov 29, 2024 •
edited
Loading

Description

tune bloom filter params of snapshot to fit higher tps

Rationale

original bloom filter size is too small for opBNB 100m block gas limit, the error rate is 1 during load test.
we adjust it to fit opBNB throughput.

Example

n/a

Changes

  1. adjust the bloom size calculation to include all diffLayers and aggregatorLayer
  2. scale up the size for bigger block gas limit of opBNB
  3. scale down the error target rate 0.02 -> 0.01

bnoieh pushed a commit to bnoieh/op-geth that referenced this pull request Nov 29, 2024
@protolambda
Merge pull request bnb-chain#230 from ethereum-optimism/seb/oplabs-se…
33cb331 
…polia-devnet-0

Bump superchain dependency to contain sepolia-dev-0 Ecotone activation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krish-nr krish-nr Awaiting requested review from krish-nr

@redhdx redhdx Awaiting requested review from redhdx

@andyzhang2023 andyzhang2023 Awaiting requested review from andyzhang2023

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bnoieh