Feat handle tx errors #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendanzhentan
changed the base branch from
main
to
chore-refactor-ProcessBotDelegatedWithdrawals
Closed
owen-reorg
approved these changes
Nov 24, 2023
welkin22
reviewed
Nov 24, 2023
bendanzhentan
force-pushed
the
feat-handle-tx-errors
branch
from
c463328
to
17ef561
Compare
owen-reorg
reviewed
Nov 24, 2023
cmd/bot/run.go
Outdated
| @@ -318,3 +330,14 @@ func queryL2ScannedBlock(db *gorm.DB, cfg *core.Config) (*core.L2ScannedBlock, e | |||
| } | |||
| return &l2ScannedBlock, nil | |||
| } | |||
|
|
|||
| // NOTE: types.L2ContractEvent.FailureReason is defined as `type:varchar(256)` in database. | |||
There was a problem hiding this comment.
why don't just use text as the type?
There was a problem hiding this comment.
Good suggestion.
Both truncating into varchar(255) and defining in text are good to me. However, text seems better. I will change to text.
There was a problem hiding this comment.
Updated at 2255cdc
bendanzhentan
force-pushed
the
feat-handle-tx-errors
branch
from
17ef561
to
2255cdc
Compare
Base automatically changed from
chore-refactor-ProcessBotDelegatedWithdrawals
to
main
November 24, 2023 09:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1 (comment)