Add unit test for "compare_modules" function #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-barzilay
requested changes
Sep 21, 2023
|
Also, you should push to next, not master |
mateuslatrova
force-pushed
the
compare_modules_test
branch
from
f7526eb to
487b5a3
Compare
mateuslatrova
force-pushed
the
compare_modules_test
branch
from
487b5a3 to
98fb469
Compare
alan-barzilay
requested changes
Oct 2, 2023
|
@mateuslatrova please squash the last 2 commits into one and LGTM |
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## next #389 +/- ##
=======================================
Coverage ? 89.96%
=======================================
Files ? 2
Lines ? 259
Branches ? 0
=======================================
Hits ? 233
Misses ? 26
Partials ? 0 ☔ View full report in Codecov by Sentry. |
mateuslatrova
force-pushed
the
compare_modules_test
branch
from
e6d2585 to
ed46d27
Compare
@alan-barzilay Done. |
alan-barzilay
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.