Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap to 0.4.10 #488

Open
4 tasks
nponeccop opened this issue May 26, 2019 · 1 comment
Open
4 tasks

Roadmap to 0.4.10 #488

nponeccop opened this issue May 26, 2019 · 1 comment

Comments

@nponeccop
Copy link

I'm going to port an in-house project from 0.4.5 and node 0.10 to 0.4.9 and node 8.x (LTS boron) as the latter seems least broken for the dependencies my project has.

So I volunteer to take over maintenance of everyauth from @bnoguchi

My tasks are essentially:

  • bump and/or fix the deps
  • fix incompatibilities
  • integrate fixes from other branches/PRs
  • do as many small/easy fixes as humanly possible

As for fixing individual providers, I'm only interested in getting the big ones working, with my arbitrary definition of "big":

  • google
  • facebook
  • twitter
  • linkedin
  • vkontakte

Of course I'll accept fixes for extra ones, but I won't test them myself.

@nponeccop
Copy link
Author

nponeccop commented Apr 6, 2020

My branch is master...nponeccop:hotfix-0.4.10

So far:

  • the package is installed without deprecation or security audit warnings with node 8.x
  • Google example in example/server.js works (as long as you change the credentials in example/conf.js, of course)
  • twitter example works too

Fixing Facebook would require an HTTPS server, because Facebook doesn't support non-https redirection URLs anymore. So I'm postponing fixing the Facebook for now, because my own app can't migrate easily to HTTPS, so I'm not motivated enough to fix Facebook as I can't use it myself.

Vkontakte I can't test due to a combination of personal and political reasons, so only LinkedIn remains to be checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant