Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast path for number to JsString conversion #4054

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

CrazyboyQCD
Copy link
Contributor

@CrazyboyQCD CrazyboyQCD commented Nov 25, 2024

This removes the intermediate String to JsString conversion.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.95%. Comparing base (6ddc2b4) to head (0cf5f2f).
Report is 305 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/property/mod.rs 60.00% 4 Missing ⚠️
core/engine/src/builtins/typed_array/object.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4054      +/-   ##
==========================================
+ Coverage   47.24%   52.95%   +5.71%     
==========================================
  Files         476      484       +8     
  Lines       46892    47201     +309     
==========================================
+ Hits        22154    24997    +2843     
+ Misses      24738    22204    -2534     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jasonwilliams jasonwilliams added the run-benchmark Label used to run banchmarks on PRs label Nov 25, 2024
@jasonwilliams
Copy link
Member

Main:

PROGRESS Richards
RESULT Richards 120
PROGRESS DeltaBlue
RESULT DeltaBlue 109
PROGRESS Encrypt
PROGRESS Decrypt
RESULT Crypto 169
PROGRESS RayTrace
RESULT RayTrace 340
PROGRESS Earley
PROGRESS Boyer
RESULT EarleyBoyer 371
PROGRESS RegExp
RESULT RegExp 86.7
PROGRESS Splay
RESULT Splay 336
PROGRESS NavierStokes
RESULT NavierStokes 369
SCORE 204

This branch:

PROGRESS Richards
RESULT Richards 120
PROGRESS DeltaBlue
RESULT DeltaBlue 108
PROGRESS Encrypt
PROGRESS Decrypt
RESULT Crypto 175
PROGRESS RayTrace
RESULT RayTrace 340
PROGRESS Earley
PROGRESS Boyer
RESULT EarleyBoyer 377
PROGRESS RegExp
RESULT RegExp 87.5
PROGRESS Splay
RESULT Splay 344
PROGRESS NavierStokes
RESULT NavierStokes 390
SCORE 207

@raskad
Copy link
Member

raskad commented Dec 3, 2024

The change looks good! @CrazyboyQCD can you rebase this on main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmark Label used to run banchmarks on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants