Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Earn: Deprecation / Refactoring / Test #217

Merged
merged 40 commits into from
Dec 13, 2023
Merged

Earn: Deprecation / Refactoring / Test #217

merged 40 commits into from
Dec 13, 2023

Conversation

sk-enya
Copy link
Collaborator

@sk-enya sk-enya commented Nov 29, 2023 •
edited
Loading

📋 closes: #59

Overview

Describe what your Pull Request is about in a few sentences.

Tasks

  • No debug console statement added
  • Should use only typescript.
  • Does have unit test for each touched file with 90% coverage
  • Does have an integration test if any UI changes.

Changes

Describe your changes and implementation choices

  • Change 1
  • Change 2
  • ...

Testing

Snapshots for test coverage for changed files.

UI Snaps

Add screenshots or video if any visuals changes are there so would be helpful for review.

@sk-enya sk-enya marked this pull request as draft November 29, 2023 16:34
@sk-enya sk-enya force-pushed the fix/deprecating-earn-and-tests branch from 8cc3441 to e4ffa1a Compare November 29, 2023 17:26
@sk-enya
cleanpup:
27273ab 
 - actions: addLiquidity, checkAllowance, earnL1, earnL2
 - component: earnDepositModal
 - cleanup modal/index.ts
 - reducers: approvedAllowance and cases for the actions
 - reducers: flag for earn deposit modal
 - services: approveERC20_L2LP, approveERC20_L1LP, addLiquidity, liquidityEstimate
@sk-enya
unused import remove from routes.ts
5d0544f
@sk-enya
cleanup:
5acb9e8 
 - removed unecessory wrapper component
 - move earn to tsx
 - updates styles import
 - updated tooltip font sizes
 - fix routeList import for Earn page
@sk-enya
removed unused code
6801dc8
@sk-enya
updated snapshot
39f849c
@sk-enya sk-enya force-pushed the fix/deprecating-earn-and-tests branch from c452852 to 39f849c Compare December 5, 2023 14:44
sk-enya added 14 commits December 6, 2023 10:23
@sk-enya
earn listing with functional handling and small components and remove…
45c05b5 
…d redundent code
@sk-enya
Changes:
2e37276 
 - refactor the earn list item.
 - earn listing of stake and rewards
 - open unstack modal
 - open harvest feature.
@sk-enya
fix: cleanup earn listing old components.
eed1577
@sk-enya
prepare liquidityPoolLayer as types for earn exported from separate f…
125b18b 
…older.
@sk-enya
change:
ebe5e37 
 - moved actions from networkAction to earnAction
 - make use of type LiquidityPoolLayer instead of EpoolLayer from network service cleanup.
@sk-enya
added unit test for earn page
ff5a779
@sk-enya
added circular loader while loading earn list
a0d8e6e
@sk-enya
unit test for the earn list and items
8a02d7a
@sk-enya
add test cases for earnlist item
5387a57
@sk-enya
fix broken test warning
4a04a68
@sk-enya
fix broken undefined function for test
cb95d13
@sk-enya
fix resolve comment
95bf55e
@sk-enya
move interfaces to types specific to earn and updated test
cb03cec
@sk-enya
updated folder name
e83be27
@sk-enya sk-enya marked this pull request as ready for review December 6, 2023 20:56
jemeza
jemeza reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@jemeza jemeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're you going to add e2e test for the earn page?

@sk-enya
change:
96aef9d 
 - fix withdraw earn stake tokens modal change
 - added withdraw token confirmation modal
 - trigger withdraw liquidity MM on confirm.
sk-enya and others added 19 commits December 9, 2023 11:09
@sk-enya
earn withdraw success modal
908510c
@sk-enya
updated snapshot
573bb40
@sk-enya
fix disable input when the value entered is empty
dc567c8
@sk-enya
updated test cases for verifier service
cad3cb4
@sk-enya
updated test id with 100% coverage
3a0dcf4
@sk-enya
cleanup unstake old modal
76a1c88
@sk-enya
unit test cases for withdraw success modal
df96ccd
@sk-enya
unit test cases for earn withdraw success / confirmation modal
97efd5f
@sk-enya
code cleanu
490fc62
@sk-enya
Merge pull request #230 from bobanetwork/fix/unstake-modal
c1bc503 
Fix/unstake modal
@sk-enya
updated snapshots
07f4a4c
@sk-enya
deleted EarnList
6f40ba3
@sk-enya
updated types for poolInfo / userinfo
551b420
@sk-enya
resolve comment for withdraw confirm modal
2f739a2
@sk-enya
fix: updated modals interface types
c4080e0
@sk-enya
loading correct modal interface
d96a5ec
@sk-enya
Merge pull request #229 from bobanetwork/fix/earn-listing
28a6ea8 
Fix/earn listing
@sk-enya
Merge branch 'main' of github.com-enya:bobanetwork/gateway into fix/d…
8c5e367 
…eprecating-earn-and-tests
@sk-enya
udpated snapshot
932e72a
@sk-enya sk-enya merged commit f1882bc into main Dec 13, 2023
3 of 5 checks passed
@sk-enya sk-enya changed the title Earn: Deprecation / Refactoring / Test / E2E Earn: Deprecation / Refactoring / Test Dec 13, 2023
@sk-enya sk-enya deleted the fix/deprecating-earn-and-tests branch December 21, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemeza jemeza jemeza left review comments

@wsdt wsdt wsdt approved these changes

@alvaro-ricotta alvaro-ricotta Awaiting requested review from alvaro-ricotta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecating "Earn"
3 participants
@sk-enya @wsdt @jemeza