Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech Debt cleanup & refactoring of network service with unit test coverage! #601

Merged
merged 29 commits into from
Aug 6, 2024
Merged

Tech Debt cleanup & refactoring of network service with unit test coverage! #601

merged 29 commits into from
Aug 6, 2024

Conversation

sk-enya
Copy link
Collaborator

@sk-enya sk-enya commented Jul 29, 2024

Cleanup Dead Code:

closes: #599
closes: #600

@sk-enya sk-enya requested review from wsdt, alvaro-ricotta and boyuan-chen and removed request for wsdt July 29, 2024 04:51
sk-enya and others added 13 commits July 29, 2024 12:02
@sk-enya
change:
c16c40a 
- removed dead codes and components.
- removed unused variables and imports.
- added script & tsconfig to find dead code
@sk-enya
change: fix spec snapshot and spy on console log to cleanup test output.
0f08190
@sk-enya
remove labeler ci action as not needed
731eabc
@sk-enya
removed export unused export
a180430
@sk-enya
change: move teleporation service to folder!
3331928
@sk-enya
change: seperated dao as separate service and cleanup unused function…
aaf2910 
…s from network services!
@sk-enya
change: earn functions to separate services to reduce network service…
3f4da56 
… deps.
@sk-enya
change:
e5bd1c8 
- cleanup earn function from network service.
- added notes on code cleanup on anchorage migration
- separate common service with axios fetch
- move gas functions to gas services from network.
@sk-enya
change: separated out the oracle specific functions
c5d808c
@sk-enya
fixed fetching earn user and pool info
b87048c
@sk-enya
fixed saving as separate service with cleaning up function from netwo…
c732704 
…rkservice.
@sk-enya
updated specs or unit test coverage
4096a11
@sk-enya
Merge pull request #602 from bobanetwork/chore/split-network-service
e4559b5 
Network Service Cleanup & Splits.
@sk-enya sk-enya changed the title Clean/devtool bobascope page Tech Debt cleanup & refactoring of network service with unit test coverage! Jul 31, 2024
boyuan-chen
boyuan-chen approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@boyuan-chen boyuan-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is too long. I will approve it first and test it in the staging env.

@sk-enya
Copy link
Collaborator Author

sk-enya commented Aug 6, 2024

Sure, make sense, there is no as such breaking changes than refactoring and adding more unit test cases! merging PR so we can test on staging and easy to address the issues!

@sk-enya sk-enya merged commit 6892cf1 into main Aug 6, 2024
3 of 5 checks passed
@sk-enya sk-enya deleted the clean/devtool-bobascope-page branch August 29, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyuan-chen boyuan-chen boyuan-chen approved these changes

@wsdt wsdt wsdt approved these changes

@alvaro-ricotta alvaro-ricotta Awaiting requested review from alvaro-ricotta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup Devtool page Cleanup Bobascope Page!
3 participants
@sk-enya @wsdt @boyuan-chen