add test to ensure tg data parsing works, fix it in general, yippee (#64

)
bobbah · Jan 31, 2025 · a9e3824 · a9e3824
1 parent 4d074af
commit a9e3824
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 6 deletions.
diff --git a/CentCom.Server/Services/TgBanService.cs b/CentCom.Server/Services/TgBanService.cs
@@ -17,14 +17,17 @@ public class TgBanService : RestBanService
 {
     private static readonly BanSource BanSource = new BanSource { Name = "tgstation" };
 
+    public static readonly JsonSerializerOptions JsonOptions = new()
+    {
+        PropertyNameCaseInsensitive = true,
+        Converters = { new JsonStringEnumConverter() }, 
+        NumberHandling = JsonNumberHandling.AllowReadingFromString
+    };
+
     public TgBanService(ILogger<TgBanService> logger) : base(logger)
     {
         // Re-initialize to control JSON serialization behaviour
-        InitializeClient(o =>o.UseSystemTextJson(new JsonSerializerOptions
-        {
-            PropertyNameCaseInsensitive = true,
-            Converters = { new JsonStringEnumConverter() }
-        }));
+        InitializeClient(o => o.UseSystemTextJson(JsonOptions));
     }
 
     protected override string BaseUrl => "https://statbus.space/";
@@ -50,7 +53,7 @@ public async Task<IEnumerable<Ban>> GetBansBatchedAsync()
             var bans = await GetBansAsync(page);
             if (bans.Count == 0)
                 break;
-            
+
             allBans.AddRange(bans);
             page++;
         }

diff --git a/CentCom.Test/BanServices/TgBanSample.json b/CentCom.Test/BanServices/TgBanSample.json
diff --git a/CentCom.Test/BanServices/TgBanServiceTests.cs b/CentCom.Test/BanServices/TgBanServiceTests.cs
@@ -0,0 +1,23 @@
+using System.IO;
+using System.Linq;
+using System.Text.Json;
+using System.Threading.Tasks;
+using CentCom.Server.External;
+using CentCom.Server.External.Raw;
+using CentCom.Server.Services;
+using Xunit;
+
+namespace CentCom.Test.BanServices;
+
+public class TgBanServiceTests
+{
+    [Fact]
+    public async Task TgBans_ShouldParseData()
+    {
+        var testData = await File.ReadAllTextAsync("BanServices/TgBanSample.json");
+        var result = JsonSerializer.Deserialize<TgApiResponse>(testData, TgBanService.JsonOptions);
+        var banData = result.Data.Select(x => x.AsBan(null));
+        Assert.NotNull(result);
+        Assert.NotEmpty(banData);
+    }
+}
diff --git a/CentCom.Test/CentCom.Test.csproj b/CentCom.Test/CentCom.Test.csproj
@@ -26,4 +26,10 @@
         <ProjectReference Include="..\CentCom.Server\CentCom.Server.csproj" />
     </ItemGroup>
 
+    <ItemGroup>
+      <None Update="BanServices\TgBanSample.json">
+        <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+      </None>
+    </ItemGroup>
+
 </Project>