Improve PassableByReference variadic placeholder param support. #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobthecow
reviewed
Nov 18, 2024
| @@ -61,6 +62,10 @@ public function enterNode(Node $node) | |||
|
|
|||
| $args = []; | |||
| foreach ($node->args as $position => $arg) { | |||
| if ($node instanceof VariadicPlaceholder) { | |||
There was a problem hiding this comment.
this should be $arg not $node, right?
There was a problem hiding this comment.
You are right! I made a mistake while moving things around. I'll fix it in the next commit.
|
thanks! |
|
Great, thanks again 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #695, this PR fixes a warning with the following code: