Remove useless line #190
Merged
Remove useless line #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this line of code was intended to support the recursive resolution case in test_chain_dependencies, ie, if the service depends on itself, then recursively resolve it, putting things in the context as you go. It's not necessary, though, since _build_impl already handles that. This fixes #169
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 2 2
Lines 172 170 -2
Branches 18 17 -1
=======================================
- Hits 172 170 -2 ☔ View full report in Codecov by Sentry. |
|
This does work, but means we're not using the context cache in tests. Really need to spend some time to remember how this is supposed to function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this line of code was intended to support the recursive resolution case in test_chain_dependencies, ie, if the service depends on itself, then recursively resolve it, putting things in the context as you go.
It's not necessary, though, since _build_impl already handles that.
This fixes #169