refactor: remove go4 dependency #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turtletowerz
changed the title
|
I'm fine leaving this where it is. If the go4.org project is ever archived or this type disappears then of course I'll reconsider slurping it in somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
go4dependency is a large library that pulls a lot of dependencies that are unnecessary for this project. Since it is licensed under the Apache 2.0 License the code can be copy/pasted verbatim with proper attribution. This PR adds the single file required to useMultiReaderAtand removes thego4dependency which significantly trims down the dependency chain and cleans upgo.sum