Support non-ascii gradient data #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When effect path (composition names, layer names, etc.) contains CJK characters, the extension failed to parse gradient data and exported black-and-whites. The bug was reported on airbnb/lottie-web#1201. This commit fixes it by adding support for parsing non-ascii gradient data.
In my test aep files, these characters are utf-8 encoded. However, reading the file with
encoding = 'UTF-8'failed because of binary data out of utf-8 byte ranges. Conversely, I tried to read the file as binary string and encodeshapeNavigations the same way, so that we can find the correctgradientIndex.Tested on After Effects 2021 (18.0.0) for MacOS. Both of AE and OS are Chinese version. Here is the demo aep file.
Chinese gradient demo.aep.zip
Before:
After:
