Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert hooking into VimEnter #37

Closed
wants to merge 8 commits into from
Closed

Revert hooking into VimEnter #37

wants to merge 8 commits into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Dec 3, 2014

This mainly reverts the hooking into VimEnter (f74d3f55), which appears to be meant as a workaround for #11.

The proper fix for #11 appears to be using bufhidden=wipe, instead of wiping the buffer during the BufNewFile event, which Vim does not appear to handle properly / as expected.

This causes a lot of issues, with both `bufdo` and `argdo`, and I cannot
see a reason why this would be required.

This reverts f74d3f55 - see
my question there.
The 'nested' autocommand should take care of this already.
@blueyed blueyed mentioned this pull request Dec 3, 2014
@bogado
Copy link
Owner

bogado commented Dec 3, 2014

This still don't work correctly with the following case:

$ vim README.md:10 plugin/file_line.vim:10 -o

I end up with two views one showing "README.md" on the correct cursor position and another one with "README.md:10". Sounds like you're wiping out the wrong buffer.

@bogado
Copy link
Owner

bogado commented Dec 3, 2014

$ vim README.md:10 plugin/file_line.vim:10 ~/.vimrc:19 -o

This will open README.md and two views of "README.md:10"

@blueyed
Copy link
Contributor Author

blueyed commented Dec 3, 2014

Too bad. I've only tested it with -p.

I'll put together a small test case an submit it to the vim issue tracker.

But for the time being, I'd say that it's already better than before going the VimEnter route.

@blueyed
Copy link
Contributor Author

blueyed commented Dec 4, 2014

@jby
Copy link

jby commented Jun 22, 2015

Any status update on this?

@blueyed
Copy link
Contributor Author

blueyed commented Jun 22, 2015

I've switched to https://github.com/kopischke/vim-fetch in the meantime, so won't maintain/update/fix this PR.

Therefore I am closing it for now, but feel free to adopt it in a new PR.

@blueyed blueyed closed this Jun 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants