Add missing event metrics from aerogear/keycloak-metrics-spi to a key…

…cloak mircometer event listener inspired by https://github.com/aerogear/keycloak-metrics-spi https://github.com/please-openit/keycloak-native-metrics https://github.com/thomasdarimont/keycloak-project-example/tree/main/keycloak/extensions/src/main/java/com/github/thomasdarimont/keycloak/custom/metrics fixes: keycloak#33043 Signed-off-by: Bernd Bohmann <[email protected]>
bohmber · Oct 9, 2024 · 7faa01b · 7faa01b
1 parent d743e34
commit 7faa01b
Show file tree

Hide file tree

Showing 3 changed files with 61 additions and 70 deletions.
diff --git a/.../org/keycloak/quarkus/runtime/services/metrics/events/MicrometerMetricsEventListener.java b/.../org/keycloak/quarkus/runtime/services/metrics/events/MicrometerMetricsEventListener.java
@@ -44,7 +44,8 @@ public class MicrometerMetricsEventListener implements GlobalEventListenerProvid
     private static final String ERROR_TAG = "error";
     private static final String EVENT_TAG = "event";
     private static final String DESCRIPTION_OF_EVENT_METER = "Keycloak user events";
-    private static final String KEYCLOAK_METER_NAME_PREFIX = "keycloak_";
+    // Micrometer naming convention that separates lowercase words with a . (dot) character.
+    private static final String KEYCLOAK_METER_NAME_PREFIX = "keycloak.";
     private static final String USER_EVENTS_METER_NAME = KEYCLOAK_METER_NAME_PREFIX + "user";
 
     private final boolean withIdp, withRealm, withClientId;

diff --git a/...ycloak/quarkus/runtime/services/metrics/events/MicrometerMetricsEventListenerFactory.java b/...ycloak/quarkus/runtime/services/metrics/events/MicrometerMetricsEventListenerFactory.java
@@ -19,15 +19,12 @@
 
 import org.bouncycastle.util.Strings;
 import org.keycloak.Config;
-import org.keycloak.events.EventType;
 import org.keycloak.events.GlobalEventListenerProvider;
 import org.keycloak.events.GlobalEventListenerProviderFactory;
 import org.keycloak.models.KeycloakSession;
 import org.keycloak.models.KeycloakSessionFactory;
 import org.keycloak.provider.EnvironmentDependentProviderFactory;
 
-import java.util.Locale;
-
 public class MicrometerMetricsEventListenerFactory implements GlobalEventListenerProviderFactory, EnvironmentDependentProviderFactory {
 
     private static final String ID = "micrometer-metrics";