Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: remove private imports for q2-types refactor #194

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

ebolyen
Copy link
Contributor

@ebolyen ebolyen commented Jul 25, 2024

Fixes some private imports.

Related to: qiime2/q2-types#342

@ebolyen
Copy link
Contributor Author

ebolyen commented Jul 25, 2024

@ebolyen
Copy link
Contributor Author

ebolyen commented Jul 25, 2024

We'll probably want to hold of on merging this until we can make a Prepare work normally.

cc @lizgehret & @Oddant1 (you have some in-progress stuff for that right?)

@ebolyen
Copy link
Contributor Author

ebolyen commented Jul 31, 2024

Tests won't pass until this is merged. We'll need another override, sorry @misialq!

@misialq
Copy link
Contributor

misialq commented Aug 27, 2024

Hey @ebolyen, super-sorry for the late message - I noticed this only now 🙈 Merging! 🚀

@misialq misialq merged commit 3f2aeec into main Aug 27, 2024
5 of 8 checks passed
@misialq misialq deleted the Trial-type-refactor branch December 20, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants