-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: co-assembling contigs from multiple samples (#22) #68
ENH: co-assembling contigs from multiple samples (#22) #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DorielaGrabocka, here are a few code suggestions :) Also, you should look at the CI and see which tests are failing - those may need some adjustments (obv, you can also do it locally). Plus introducing a new test for testing the co-assembly :)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
- Coverage 98.54% 98.28% -0.26%
==========================================
Files 25 27 +2
Lines 1443 1752 +309
==========================================
+ Hits 1422 1722 +300
- Misses 21 30 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DorielaGrabocka, see some comments below - I'm still trying the code out on some samples ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @DorielaGrabocka! 🏅
This draft PR contains code for co-assembly in MEGAHIT
Depends on: qiime2/q2-types#314.