Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: co-assembling contigs from multiple samples (#22) #68

Merged
merged 16 commits into from
Mar 25, 2024

Conversation

DorielaGrabocka
Copy link
Contributor

@DorielaGrabocka DorielaGrabocka commented Dec 15, 2023

This draft PR contains code for co-assembly in MEGAHIT

Depends on: qiime2/q2-types#314.

Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DorielaGrabocka, here are a few code suggestions :) Also, you should look at the CI and see which tests are failing - those may need some adjustments (obv, you can also do it locally). Plus introducing a new test for testing the co-assembly :)

@misialq misialq added this to the Manuscript prep milestone Jan 11, 2024
@misialq misialq added the enhancement New feature or request label Jan 11, 2024
@misialq misialq removed this from the Manuscript prep milestone Jan 11, 2024
@misialq misialq linked an issue Jan 11, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: Patch coverage is 96.64804% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 98.28%. Comparing base (debd89a) to head (71dd4eb).
Report is 4 commits behind head on main.

Files Patch % Lines
q2_assembly/megahit/megahit.py 76.47% 4 Missing ⚠️
q2_assembly/_utils.py 92.85% 1 Missing ⚠️
q2_assembly/spades/tests/test_spades.py 97.56% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   98.54%   98.28%   -0.26%     
==========================================
  Files          25       27       +2     
  Lines        1443     1752     +309     
==========================================
+ Hits         1422     1722     +300     
- Misses         21       30       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DorielaGrabocka, see some comments below - I'm still trying the code out on some samples ;)

@misialq misialq marked this pull request as ready for review February 22, 2024 07:26
Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @DorielaGrabocka! 🏅

@misialq misialq merged commit fd3ae4c into bokulich-lab:main Mar 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: implement co-assembly option
2 participants