Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more types genomics #71

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Conversation

Oddant1
Copy link
Contributor

@Oddant1 Oddant1 commented Feb 13, 2024

Change types_genomics to types in accordance with qiime2/q2-types#309

Blocked by qiime2/q2-types#309

Copy link
Contributor

@lizgehret lizgehret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks reasonable - pending local testing, i'll merge the blocking PR in types and then we can re-run CI to make sure everything passes.

Copy link

This PR/issue depends on: * qiime2/q2-types#309

@lizgehret
Copy link
Contributor

ah, i figured out why this (and the PR in moshpit) are still failing. i ran a Prepare using amplicon (thinking that would be an easier rebuild than another shotgun, due to the distro size) - but these plugins will only look under the shotgun channel for newly built packages, so the changes from q2-types aren't being pulled in. I'm going to run a new Prepare for shotgun to get this sorted and then re-running these should be successful.

@lizgehret
Copy link
Contributor

Okay so unfortunately this is a bit of a chicken and egg situation - CI won't pass here until there's a working metapackage build, and the metapackage won't build until these changes take into effect (failed metapackage shown here). These PRs need to get merged before an updated shotgun metapackage can be built successfully. @nbokulich is it possible to override the required statuses passing and get this PR (along with the RESCRIPt and moshpit PRs) merged?

@nbokulich
Copy link
Contributor

Thanks for the notification @lizgehret ! Merging this to resolve the chicken-vs-egg problem

@nbokulich nbokulich merged commit edeefe2 into bokulich-lab:main Feb 15, 2024
5 of 7 checks passed
DorielaGrabocka pushed a commit to DorielaGrabocka/q2-assembly that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants