-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No more types genomics #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this all looks reasonable - pending local testing, i'll merge the blocking PR in types and then we can re-run CI to make sure everything passes.
This PR/issue depends on: * |
ah, i figured out why this (and the PR in moshpit) are still failing. i ran a Prepare using amplicon (thinking that would be an easier rebuild than another shotgun, due to the distro size) - but these plugins will only look under the shotgun channel for newly built packages, so the changes from q2-types aren't being pulled in. I'm going to run a new Prepare for shotgun to get this sorted and then re-running these should be successful. |
Okay so unfortunately this is a bit of a chicken and egg situation - CI won't pass here until there's a working metapackage build, and the metapackage won't build until these changes take into effect (failed metapackage shown here). These PRs need to get merged before an updated shotgun metapackage can be built successfully. @nbokulich is it possible to override the required statuses passing and get this PR (along with the RESCRIPt and moshpit PRs) merged? |
Thanks for the notification @lizgehret ! Merging this to resolve the chicken-vs-egg problem |
Change types_genomics to types in accordance with qiime2/q2-types#309
Blocked by qiime2/q2-types#309