Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix propagation of ZREP_INC_FLAG when doing zrep refresh #197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janvrany
Copy link

When doing zrep refresh, ZREP_INC_FLAG setting (on "refreshing" side) was (prior this commit) ignored, falling back to default setting.

This is because the value ZREP_INC_FLAG was not propagated to the other ("sending") side. One way would be to set it in /etc/default/zrep on the "sending" side - but this is both fiddly and sets it for all (that is, you cannot have one "refreshing" site using -i and the other using -I)

Better solution is to simply propagate the setting to the other side, which is what this commit does.

When doing `zrep refresh`, `ZREP_INC_FLAG` setting (on "refreshing" side)
was (prior this commit) ignored, falling back to default setting.

This is because the value `ZREP_INC_FLAG` was not propagated to the other
("sending") side. One way would be to set it in `/etc/default/zrep` on the
"sending" side - but this is both fiddly and sets it for all (that is,
you cannot have one "refreshing" site using `-i` and the other using `-I`)

Better solution is to simply propagate the setting to the other side,
which is what this commit does.
@ppbrown
Copy link
Member

ppbrown commented May 29, 2023

Thank you both for your continued interest in zrep.
It is the interaction with folks like yourself, that give me the motivational bump to keep maintaining it.
I see the need for this.. however, I dont thing the proposed method of adding a special argument to the hidden function, is the best way to go.
I'm reviewing the code for a cleaner way to handle this

@ppbrown
Copy link
Member

ppbrown commented May 29, 2023

Aha.
I had previously HALF solved this problem, by the hack of the ZREP_SEND_FLAGS

But that doesnt transfer over well when $BBCP is in the way.
So to be consistent, I probably need to make ZREP_SEND_FLAGS a full top level option, rather than a variable hack.

@ppbrown
Copy link
Member

ppbrown commented Jun 3, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants