Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keygen output constructor and tests #478

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

marsella
Copy link

Closes #376

This adds into_parts and from_parts methods for keygen output so that we can reconstruct them in products that need to store the output. It also:

  • Moves the keygen output to its own module
  • Updates the simulate methods for keygen and auxinfo to only produce valid outputs
  • Updates the presign input validation to reduce double-checking of things that are already checked in the individual output constructors.

src/presign/input.rs Show resolved Hide resolved
src/presign/input.rs Show resolved Hide resolved
src/keygen/output.rs Show resolved Hide resolved
src/keygen/output.rs Show resolved Hide resolved
src/auxinfo/output.rs Show resolved Hide resolved
Copy link

@gatoWololo gatoWololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Looks good to me.

Copy link

@hridambasu hridambasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far with Omar's points.

@marsella marsella merged commit b0abeba into main Aug 25, 2023
2 checks passed
@marsella marsella deleted the 376-add-keygen-methods branch August 25, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add storage-related methods to keygen output
3 participants